unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: mario@lassnig.net, cyd@gnu.org, 9772@debbugs.gnu.org,
	9960@debbugs.gnu.org, 10155@debbugs.gnu.org
Subject: bug#9772: OSX breakage
Date: Tue, 29 Nov 2011 18:39:56 +0200	[thread overview]
Message-ID: <83obvu6fxf.fsf@gnu.org> (raw)
In-Reply-To: <4ED4A5BE.80008@cs.ucla.edu>

> Date: Tue, 29 Nov 2011 01:28:30 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: Eli Zaretskii <eliz@gnu.org>, mario@lassnig.net, 
>  9772@debbugs.gnu.org, 9960@debbugs.gnu.org, 10155@debbugs.gnu.org
> 
> On 11/28/11 21:00, Chong Yidong wrote:
> > As Eli pointed out in the discussion on bug#10155, there is already code
> > in lib/unistd.in.h that apparently ought to handle this, but itsn't
> > working.
> 
> Here's a proposed patch to fix that, by having Emacs use Gnulib's
> environ module.  This syncs from Gnulib, and so it also brings
> in the patches for Bug#9772 and Bug#9960.  (It is possible to
> pull out just the environ fix by hand, but that's an error-prone process
> and I'd rather avoid it.)  I have tested this on Fedora 15,
> but not on OSX nor on Windows.

FWIW, I'd very much prefer not to install such large changes a day or
two before the next pretest.  If the only practical way of fixing this
within gnulib is the proposed changeset, I'd say let's just add a
declaration of environ conditioned on OS X and FreeBSD.  I don't like
this solution, but I think on balance it has less potential for
destabilizing the build.





  parent reply	other threads:[~2011-11-29 16:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4ED3AA79.8060605@lassnig.net>
     [not found] ` <838vn06swa.fsf@gnu.org>
     [not found]   ` <4ED3DA30.1050006@cs.ucla.edu>
     [not found]     ` <871usrh69t.fsf@gnu.org>
2011-11-29  9:28       ` bug#9772: OSX breakage Paul Eggert
2011-11-29 13:56         ` bug#9960: bug#10155: " Stefan Monnier
2011-11-29 16:58           ` Paul Eggert
2011-11-29 17:30             ` bug#9772: " Eli Zaretskii
2011-11-29 18:22               ` bug#9960: " Paul Eggert
2011-11-30  2:45                 ` bug#10155: bug#9772: " Chong Yidong
2011-11-30  4:04                   ` Eli Zaretskii
2011-11-30  8:14                     ` Chong Yidong
2011-11-30 11:15                       ` bug#10155: " Mario Lassnig
2011-12-01 16:12                         ` Paul Eggert
2011-11-30 17:48                       ` bug#10155: " Jan Djärv
2011-11-29 16:39         ` Eli Zaretskii [this message]
2011-11-30  2:27           ` bug#9772: " Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83obvu6fxf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=10155@debbugs.gnu.org \
    --cc=9772@debbugs.gnu.org \
    --cc=9960@debbugs.gnu.org \
    --cc=cyd@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=mario@lassnig.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).