From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 13553@debbugs.gnu.org, shigeru.fukaya@gmail.com
Subject: bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP
Date: Sat, 26 Jan 2013 13:16:50 +0200 [thread overview]
Message-ID: <83obgcjisd.fsf@gnu.org> (raw)
In-Reply-To: <jwvsj5oqm66.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sat, 26 Jan 2013 05:26:04 -0500
> Cc: 13553@debbugs.gnu.org
>
> > It is because IS_DIRECTORY_SEP is wrongly used.
> > IS_DIRECTORY_SEP only works when its argument is surely on a start
> > byte of dbcs characters.
>
> If the file name is properly decoded (i.e. in its multibyte form), there
> can't be a 0x5c byte other than at the beginning of a char.
>
> So this bug can only happens if you pass a unibyte filename. IOW the
> bug is probably in the caller rather than in the file-attributes function.
No, it's not in the caller. It's in w32.c, whose functions almost
always manipulate encoded file names (because they shadow system
APIs).
> Please show us the actual situation where this happens, since file names
> are normally always multibyte.
You call file-attributes, which encodes the file name and passes it to
'lstat'. The implementation of 'lstat' in w32.c then looks at the
last byte of the encoded file name to see if there's a slash or
backslash there. Boom!
I will fix that.
next prev parent reply other threads:[~2013-01-26 11:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 5:52 bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP Shigeru Fukaya
2013-01-26 10:26 ` Stefan Monnier
2013-01-26 11:16 ` Eli Zaretskii [this message]
2013-01-26 12:40 ` Stefan Monnier
2013-01-26 13:23 ` Eli Zaretskii
2013-01-26 22:24 ` Stefan Monnier
2013-01-27 7:06 ` Eli Zaretskii
2013-01-27 8:36 ` Shigeru Fukaya
2013-01-27 9:40 ` Eli Zaretskii
2013-01-26 12:56 ` Eli Zaretskii
2013-01-26 14:06 ` Eli Zaretskii
2013-01-26 16:33 ` Shigeru Fukaya
2013-01-26 17:37 ` Eli Zaretskii
2013-01-27 6:56 ` Shigeru Fukaya
2013-01-27 7:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83obgcjisd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13553@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=shigeru.fukaya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).