From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15866: Gnutls elisp code doesn't properly check for file existence Date: Tue, 12 Nov 2013 19:48:18 +0200 Message-ID: <83ob5p1pgd.fsf@gnu.org> References: <21121.29752.814965.329395@consult.pretender> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1384278556 31567 80.91.229.3 (12 Nov 2013 17:49:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Nov 2013 17:49:16 +0000 (UTC) Cc: 15866@debbugs.gnu.org To: emacs@kosowsky.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 12 18:49:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VgI5W-0004re-Oo for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Nov 2013 18:49:18 +0100 Original-Received: from localhost ([::1]:44434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgI5W-0001Ww-Dy for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Nov 2013 12:49:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgI5N-0001WX-4l for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2013 12:49:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgI5G-0008Fk-Ve for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2013 12:49:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgI5G-0008Ff-Rw for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2013 12:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VgI5G-0008TN-H3 for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2013 12:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Nov 2013 17:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15866 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15866-submit@debbugs.gnu.org id=B15866.138427851132505 (code B ref 15866); Tue, 12 Nov 2013 17:49:02 +0000 Original-Received: (at 15866) by debbugs.gnu.org; 12 Nov 2013 17:48:31 +0000 Original-Received: from localhost ([127.0.0.1]:49072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgI4k-0008SD-BM for submit@debbugs.gnu.org; Tue, 12 Nov 2013 12:48:30 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:57547) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgI4h-0008Rx-8z for 15866@debbugs.gnu.org; Tue, 12 Nov 2013 12:48:28 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MW500J00VTWPI00@a-mtaout22.012.net.il> for 15866@debbugs.gnu.org; Tue, 12 Nov 2013 19:48:20 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MW500JK6W4KID50@a-mtaout22.012.net.il>; Tue, 12 Nov 2013 19:48:20 +0200 (IST) In-reply-to: <21121.29752.814965.329395@consult.pretender> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80336 Archived-At: > Date: Mon, 11 Nov 2013 19:20:08 -0500 > From: "" > > i] If the function 'expand-file-name' has an associated magic file > handler, the function expand-file-name is called to convert it "to > absolute, and canonicalize it" (quoted from the function > definition). > > ii] The test for file-exists-p is then wrapped in a 'let' construct > with file-name-handler-alist set to nil. This effectively shuts > off magic file handling and ensures that file-exists-p now checks > for true OS existence of the now potentially expanded path. > > iii]The function gnutls-trustfiles is now assured that it will be > passed an OS-valid path. Thanks. As I wrote elsewhere, I agree that gnutls.el should ignore file handlers when it looks for certificate files. But then _not_ ignoring the expand-file-name handler makes little sense to me: the result could exist as a local file name that has no relation whatsoever to certificates, which will again fail in strange ways inside the GnuTLS library. So I think we should do ii], but not i]. Btw, I think many Emacs packages don't make sense with remote files, so they should also ignore file handlers. IOW, this is not specific to gnutls.el.