From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17210: 24.3.50; help mode [back] link to a C-h b keybind listing fails with message "Current buffer is not in Help mode" Date: Mon, 07 Apr 2014 18:54:39 +0300 Message-ID: <83ob0d6sow.fsf@gnu.org> References: <5341E798.4060004@iankelling.org> <5342585B.9070603@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1396886125 2120 80.91.229.3 (7 Apr 2014 15:55:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Apr 2014 15:55:25 +0000 (UTC) Cc: ian@iankelling.org, 17210@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 07 17:55:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WXBtF-0005RV-TD for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Apr 2014 17:55:18 +0200 Original-Received: from localhost ([::1]:35398 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXBtF-0000OM-G5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Apr 2014 11:55:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXBt6-0000Is-Pu for bug-gnu-emacs@gnu.org; Mon, 07 Apr 2014 11:55:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXBt0-00023O-TY for bug-gnu-emacs@gnu.org; Mon, 07 Apr 2014 11:55:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXBt0-000235-Q3 for bug-gnu-emacs@gnu.org; Mon, 07 Apr 2014 11:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WXBsz-00052x-Le for bug-gnu-emacs@gnu.org; Mon, 07 Apr 2014 11:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Apr 2014 15:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17210 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17210-submit@debbugs.gnu.org id=B17210.139688609719383 (code B ref 17210); Mon, 07 Apr 2014 15:55:01 +0000 Original-Received: (at 17210) by debbugs.gnu.org; 7 Apr 2014 15:54:57 +0000 Original-Received: from localhost ([127.0.0.1]:39760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXBsu-00052Y-A0 for submit@debbugs.gnu.org; Mon, 07 Apr 2014 11:54:56 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:36913) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXBsp-00052A-Cl for 17210@debbugs.gnu.org; Mon, 07 Apr 2014 11:54:53 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0N3O007003TXK000@mtaout24.012.net.il> for 17210@debbugs.gnu.org; Mon, 07 Apr 2014 18:52:54 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N3O0057W445AF40@mtaout24.012.net.il>; Mon, 07 Apr 2014 18:52:54 +0300 (IDT) In-reply-to: <5342585B.9070603@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87854 Archived-At: > Date: Mon, 07 Apr 2014 09:48:43 +0200 > From: martin rudalics > > > Debugger entered--Lisp error: (error "Current buffer is not in Help mode") > > signal(error ("Current buffer is not in Help mode")) > > error("Current buffer is not in Help mode") > > help-buffer() > > describe-bindings-internal(nil nil) > > describe-bindings(nil #) > > apply(describe-bindings (nil #)) > > help-xref-go-back(#) > > apply(help-xref-go-back #) > > help-do-xref(63 help-xref-go-back (#)) > > help-button-action(#) > > button-activate(# nil) > > push-button(66) > > push-button((mouse-2 (# 66 (34 . 106) 107906261 nil 66 (3 . > > 5) nil (7 . 11) (9 . 19)))) > > call-interactively(push-button nil nil) > > command-execute(push-button) > > Confirmed. Thanks for caring to provide a simple scenario. > > I could fix this by restoring the code of `describe-bindings-internal' > from Emacs 24.3. But the behavior of `help-xref-go-back' here is > erratic per se: It does not restore the earlier contents of the bindings > from the *scratch* buffer but IIUC those of the *Help* buffer and I'm > not sure whether that's what we want (I think we don't). Can you tell why you replaced a literal "*Help*" with a call to help-buffer? That change was part of your pixel-resizing changes, but it doesn't sound related to me, and the ChangeLog entry doesn't provide any explanations to convince me otherwise. Also, describe-bindings-internal is only called from this single place, so I see no reason to support some other help buffers. Do you?