From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: ian@iankelling.org, 17210@debbugs.gnu.org
Subject: bug#17210: 24.3.50; help mode [back] link to a C-h b keybind listing fails with message "Current buffer is not in Help mode"
Date: Mon, 07 Apr 2014 18:54:39 +0300 [thread overview]
Message-ID: <83ob0d6sow.fsf@gnu.org> (raw)
In-Reply-To: <5342585B.9070603@gmx.at>
> Date: Mon, 07 Apr 2014 09:48:43 +0200
> From: martin rudalics <rudalics@gmx.at>
>
> > Debugger entered--Lisp error: (error "Current buffer is not in Help mode")
> > signal(error ("Current buffer is not in Help mode"))
> > error("Current buffer is not in Help mode")
> > help-buffer()
> > describe-bindings-internal(nil nil)
> > describe-bindings(nil #<buffer *scratch*>)
> > apply(describe-bindings (nil #<buffer *scratch*>))
> > help-xref-go-back(#<buffer *Help*>)
> > apply(help-xref-go-back #<buffer *Help*>)
> > help-do-xref(63 help-xref-go-back (#<buffer *Help*>))
> > help-button-action(#<marker (moves after insertion) at 66 in *Help*>)
> > button-activate(#<marker (moves after insertion) at 66 in *Help*> nil)
> > push-button(66)
> > push-button((mouse-2 (#<window 6 on *Help*> 66 (34 . 106) 107906261 nil 66 (3 .
> > 5) nil (7 . 11) (9 . 19))))
> > call-interactively(push-button nil nil)
> > command-execute(push-button)
>
> Confirmed. Thanks for caring to provide a simple scenario.
>
> I could fix this by restoring the code of `describe-bindings-internal'
> from Emacs 24.3. But the behavior of `help-xref-go-back' here is
> erratic per se: It does not restore the earlier contents of the bindings
> from the *scratch* buffer but IIUC those of the *Help* buffer and I'm
> not sure whether that's what we want (I think we don't).
Can you tell why you replaced a literal "*Help*" with a call to
help-buffer? That change was part of your pixel-resizing changes, but
it doesn't sound related to me, and the ChangeLog entry doesn't
provide any explanations to convince me otherwise.
Also, describe-bindings-internal is only called from this single
place, so I see no reason to support some other help buffers. Do you?
next prev parent reply other threads:[~2014-04-07 15:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 23:47 bug#17210: 24.3.50; help mode [back] link to a C-h b keybind listing fails with message "Current buffer is not in Help mode" Ian Kelling
2014-04-07 7:48 ` martin rudalics
2014-04-07 15:54 ` Eli Zaretskii [this message]
2014-04-07 18:17 ` Stefan Monnier
2014-04-08 7:14 ` martin rudalics
2014-04-08 8:32 ` Juri Linkov
2014-04-08 9:18 ` martin rudalics
2014-04-08 15:27 ` Eli Zaretskii
2014-04-08 16:34 ` martin rudalics
2014-04-08 16:42 ` Eli Zaretskii
2014-04-08 17:01 ` martin rudalics
2014-04-08 17:08 ` martin rudalics
2014-04-08 17:16 ` Andreas Schwab
2014-04-08 7:13 ` martin rudalics
2014-04-08 15:26 ` Eli Zaretskii
2014-04-08 19:49 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ob0d6sow.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=17210@debbugs.gnu.org \
--cc=ian@iankelling.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).