From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18136: 24.4.50; crash in redisplay when calling load-theme Date: Thu, 31 Jul 2014 13:52:40 +0300 Message-ID: <83oaw5ssuf.fsf@gnu.org> References: <87d2cpxaq1.fsf@holos.localdomain> <8338dkh6wo.fsf@gnu.org> <53D77B06.8040907@gmx.at> <83tx60fjnh.fsf@gnu.org> <53D7A965.30700@gmx.at> <83mwbste5o.fsf@gnu.org> <53D7C0C4.7070406@gmx.at> <83iomgt9d2.fsf@gnu.org> <53D7E6B6.6070007@gmx.at> <83fvhkt3wm.fsf@gnu.org> <53D9210E.2030800@gmx.at> <8361ieu5nr.fsf@gnu.org> <53D92D00.7070600@gmx.at> <831tt2u428.fsf@gnu.org> <53DA0307.6040004@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1406804005 11597 80.91.229.3 (31 Jul 2014 10:53:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Jul 2014 10:53:25 +0000 (UTC) Cc: mvoteiza@udel.edu, 18136@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 31 12:53:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XCnz3-0000wY-Hc for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Jul 2014 12:53:17 +0200 Original-Received: from localhost ([::1]:55609 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCnz3-0008FI-7C for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Jul 2014 06:53:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCnyv-0008E4-G8 for bug-gnu-emacs@gnu.org; Thu, 31 Jul 2014 06:53:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCnyp-0004O1-7S for bug-gnu-emacs@gnu.org; Thu, 31 Jul 2014 06:53:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCnyp-0004Nu-4L for bug-gnu-emacs@gnu.org; Thu, 31 Jul 2014 06:53:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XCnyo-0007ta-EY for bug-gnu-emacs@gnu.org; Thu, 31 Jul 2014 06:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Jul 2014 10:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18136 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18136-submit@debbugs.gnu.org id=B18136.140680395130309 (code B ref 18136); Thu, 31 Jul 2014 10:53:02 +0000 Original-Received: (at 18136) by debbugs.gnu.org; 31 Jul 2014 10:52:31 +0000 Original-Received: from localhost ([127.0.0.1]:52561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XCnyI-0007sm-Ge for submit@debbugs.gnu.org; Thu, 31 Jul 2014 06:52:30 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:48158) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XCnyD-0007sS-VX for 18136@debbugs.gnu.org; Thu, 31 Jul 2014 06:52:27 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N9K00A00OEDGU00@mtaout25.012.net.il> for 18136@debbugs.gnu.org; Thu, 31 Jul 2014 13:47:39 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N9K00BE2ONFGN00@mtaout25.012.net.il>; Thu, 31 Jul 2014 13:47:39 +0300 (IDT) In-reply-to: <53DA0307.6040004@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92000 Archived-At: > Date: Thu, 31 Jul 2014 10:49:11 +0200 > From: martin rudalics > CC: mvoteiza@udel.edu, 18136@debbugs.gnu.org > > But I don't really understand about `set-frame-height' and friends on a > TTY and what they are supposed to do. Should these be allowed to change > the frame size? Yes. > Now about the > > change_frame_size (XFRAME (selected_frame), > FrameCols (t->display_info.tty), > FrameRows (t->display_info.tty) > - FRAME_MENU_BAR_LINES (f), 0, 0, 1, 0); > > call in init_display. What precisely is this supposed to accomplish? Allocate the glyph matrices, at the very least, I guess. > Back to init_display and the question I asked earlier: Why should the > subsequent adjust_frame_size call do > > if ((FRAME_TERMCAP_P (f) && !pretend) || FRAME_MSDOS_P (f)) > FrameRows (FRAME_TTY (f)) = new_lines; > > here? Maybe it shouldn't, when called from init_display. But we should at least leave an eassert there, in case we overlook something. In any case, this begs the question: why do you at all call adjust_frame_size in this case, if the frame already has the required size? I think the answer is that adjust_frame_size does something else: it calls adjust_frame_glyphs. That call is required at init_display time for obvious reasons, but it is inside adjust_frame_size which is only called when the frame size changes, which sounds like a contradiction in the design. > Now please tell me one thing: Which calls of change_frame_size or > adjust_frame_size _should_ set FrameRows or FrameCols Any calls that actually change the frame size. > and how can I distinguish them? You already do, if I understand your description. You already avoid calling adjust_frame_size unless the size really changes.