unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Da Zhang <zhangda82@gmail.com>
Cc: 20744@debbugs.gnu.org
Subject: bug#20744: shell-quote-argument in Emacs 24.5 and Emacs 25 on Windows cannot figure out path correctly
Date: Fri, 05 Jun 2015 23:13:18 +0300	[thread overview]
Message-ID: <83oaktoqw1.fsf@gnu.org> (raw)
In-Reply-To: <5571CF77.5000902@gmail.com>

> Date: Fri, 05 Jun 2015 12:33:59 -0400
> From: Da Zhang <zhangda82@gmail.com>
> 
> I use python mode (python.el) for some python programming. When I invoke
> the command python-shell-send-buffer, my Emacs always reports "Searching
> for program: no such file or directory,
> c\:/Anaconda3/Scripts/ipython.exe".
> 
> I traced down the cause of this problem, and found the following lines
> in python.el:
> (defun python-shell-parse-command () ;FIXME: why name it "parse"?
> "Calculate the string used to execute the inferior Python process."
> ;; FIXME: process-environment doesn't seem to be used anywhere within
> ;; this let.
> (let ((process-environment (python-shell-calculate-process-environment))
> (exec-path (python-shell-calculate-exec-path)))
> (format "%s %s"
> ;; FIXME: Why executable-find?
> (shell-quote-argument (executable-find python-shell-interpreter))
> python-shell-interpreter-args)))
> 
> The function call 
> (shell-quote-argument (executable-find python-shell-interpreter))
> changed the path of my python interpreter from
> "c:/Anaconda3/Scripts/ipython.exe"
> to
> "c\\:/Anaconda3/Scripts/ipython.exe".
> 
> I worked around this problem by replacing the function call
> (shell-quote-argument (executable-find python-shell-interpreter))
> with
> (executable-find python-shell-interpreter) ;; edited by DZ on
> 2015/06/05: (shell-quote-argument) caused the problem of
> "c\\:/Anaconda3/Scripts/ipython.exe"
> 
> To further analyze the problem, I found the function
> shell-quote-argument defined in subr.el does not deal with the case when
> bash from cygwin is used.

For the record, this is bug #20237.

> I added the following lines in the cond statement, to solve the problem.
> ((and (eq system-type 'windows-nt) (if (string-match ".*cygwin.*"
> (w32-shell-name)) t nil)) ;; DZ's edit on 6/5/2015
> (if (equal argument "")
> "''"
> ;; Quote everything except POSIX filename characters.
> ;; This should be safe enough even for really weird shells.
> (replace-regexp-in-string
> "\n" "'\n'"
> (replace-regexp-in-string "[^-0-9a-zA-Z_./\n:]" "\\\\\\&" argument))))

I'm sorry, but I don't see how we can accept such a change: it means
that when the Cygwin Bash is used as the shell, the ':' character will
not be quoted, which I think could cause trouble in some cases.

Maybe some Bash expert could chime in and tell whether problems are
possible with Bash in this case.

Is there any way you could avoid using the Cygwin Bash as the shell
when running the native Windows build of Emacs?  That would make the
problem go away without any need for changes.





  reply	other threads:[~2015-06-05 20:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 16:33 bug#20744: shell-quote-argument in Emacs 24.5 and Emacs 25 on Windows cannot figure out path correctly Da Zhang
2015-06-05 20:13 ` Eli Zaretskii [this message]
2015-06-05 20:50   ` Da Zhang
2015-06-05 21:05   ` Da Zhang
2015-06-07 18:01   ` Glenn Morris
2015-06-07 19:11     ` Eli Zaretskii
2015-06-08  0:07       ` Glenn Morris
2015-06-08  0:24         ` Glenn Morris
2015-06-08  0:47           ` Glenn Morris
2015-06-08  2:43             ` Eli Zaretskii
2015-06-08  7:43               ` Michael Albinus
2015-06-08 14:31                 ` Eli Zaretskii
2015-06-08 15:14                   ` Michael Albinus
2015-06-08 16:22                     ` Eli Zaretskii
2015-06-08 16:34                       ` Michael Albinus
2015-06-08 14:03         ` Stefan Monnier
2016-08-10  0:51 ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83oaktoqw1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=20744@debbugs.gnu.org \
    --cc=zhangda82@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).