From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21707: include-file cleanup for src directory Date: Tue, 20 Oct 2015 18:06:00 +0300 Message-ID: <83oaftfulj.fsf@gnu.org> References: <56249650.5050804@cs.ucla.edu> <83vba3gw4p.fsf@gnu.org> <5625D71F.402@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1445353655 14312 80.91.229.3 (20 Oct 2015 15:07:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 Oct 2015 15:07:35 +0000 (UTC) Cc: 21707@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 20 17:07:24 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZoYVT-0006Ia-6B for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Oct 2015 17:07:19 +0200 Original-Received: from localhost ([::1]:46258 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoYVS-0003L1-Mb for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Oct 2015 11:07:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoYVI-0003Ik-Eh for bug-gnu-emacs@gnu.org; Tue, 20 Oct 2015 11:07:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoYVD-0006l6-7q for bug-gnu-emacs@gnu.org; Tue, 20 Oct 2015 11:07:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoYVD-0006kS-4Y for bug-gnu-emacs@gnu.org; Tue, 20 Oct 2015 11:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZoYVC-00029E-Ag for bug-gnu-emacs@gnu.org; Tue, 20 Oct 2015 11:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Oct 2015 15:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21707 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21707-submit@debbugs.gnu.org id=B21707.14453535708187 (code B ref 21707); Tue, 20 Oct 2015 15:07:02 +0000 Original-Received: (at 21707) by debbugs.gnu.org; 20 Oct 2015 15:06:10 +0000 Original-Received: from localhost ([127.0.0.1]:58149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZoYUI-00027u-P7 for submit@debbugs.gnu.org; Tue, 20 Oct 2015 11:06:10 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:62359) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZoYUD-00027Q-O5 for 21707@debbugs.gnu.org; Tue, 20 Oct 2015 11:06:05 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NWI00100XPUBB00@a-mtaout22.012.net.il> for 21707@debbugs.gnu.org; Tue, 20 Oct 2015 18:05:56 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWI0015BXXV3I30@a-mtaout22.012.net.il>; Tue, 20 Oct 2015 18:05:55 +0300 (IDT) In-reply-to: <5625D71F.402@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107778 Archived-At: > Cc: 21707@debbugs.gnu.org > From: Paul Eggert > Date: Mon, 19 Oct 2015 22:54:39 -0700 > > Eli Zaretskii wrote: > > I had compilation warnings and errors due to redisplaying_p and > > cancel_hourglass not being declared in eval.c and lread.c. These two > > files need to include dispextern.h to avoid that problem. (This isn't > > Windows specific, so I wonder how it compiled for you.) > > It's a problem with platform-specific inclusions: xterm.h includes dispextern.h, > but eval.c and lread.c don't include xterm.h on MS-Windows. I attempted to > detect this sort of thing by hand without actually building on MS-Windows, but > it's an easy thing to get wrong. I see. Would it help if we avoid including any of our headers in any other of our headers, so that the headers included by a particular C file are visible by just looking at that single C file? At least then any system dependencies will be explicitly stated in each C file. > Revised patch attached. Thanks, this works for me.