From: Eli Zaretskii <eliz@gnu.org>
To: phillip.lord@russet.org.uk (Phillip Lord)
Cc: 23203@debbugs.gnu.org, stromeko@nexgo.de
Subject: bug#23203: 25.0.91; some loaddefs files have auto-save remnants after building (and install doesn't ignore them)
Date: Fri, 08 Apr 2016 11:22:50 +0300 [thread overview]
Message-ID: <83oa9kjyqt.fsf@gnu.org> (raw)
In-Reply-To: <87wpodyqdy.fsf@russet.org.uk> (phillip.lord@russet.org.uk)
> From: phillip.lord@russet.org.uk (Phillip Lord)
> Cc: 23203@debbugs.gnu.org, stromeko@nexgo.de
> Date: Mon, 04 Apr 2016 23:12:57 +0100
>
> > How about this alternative: only disable backing up the initial
> > (effectively empty) contents of the autoloads file? AFAICT, the
> > backup files are created during a bootstrap only because we first
> > write the initial "rubric" into it, using write-region, and only after
> > that visit it. This defeats the normal mechanism of backing up just
> > once per session, and leaves a backup file whose contents are not
> > interesting.
>
> That sounds plausible.
>
> >
> > So an alternative would be to modify autoload-ensure-default-file so
> > that it returns some indication about the fact it created the file,
> > and then change its caller to set buffer-backed-up after it visits the
> > file, thus preventing the backup _only_ when the file is first
> > created.
> >
> > This should at least solve Achim's problem, but without affecting
> > anything else.
> >
> > WDYT?
>
> Also, it sounds reasonable -- I've attached a patch with a variation on
> this theme.
Thanks. There seem to be spurious unrelated whitespace changes in the
patch.
Also, wouldn't it be more elegant to have autoload-ensure-default-file
return a cons cell reporting whether the file did exist before, so
that autoload-find-generated-file could act on that? But if you
prefer your implementation, I won't argue.
> My concerns is that we will still produce backup files which may end up
> in a dist build. Consider these commands:
>
> make (from bootstrap)
> rm lisp/loaddefs.el
> make
>
> Removing loaddefs will result in generation of all the associated
> loaddef files, all of which will now be backups.
>
> So, we need to make sure that the packaging system does not copy backup
> files.
"make install" already removes backup files from the target tree, so
is there any problem left?
next prev parent reply other threads:[~2016-04-08 8:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 7:08 bug#23203: 25.0.91; some loaddefs files have auto-save remnants after building (and install doesn't ignore them) Achim Gratz
2016-04-03 8:26 ` Andreas Schwab
2016-04-03 8:28 ` Andreas Schwab
2016-04-03 8:48 ` Achim Gratz
2016-04-03 10:46 ` Andreas Schwab
2016-04-03 11:47 ` Achim Gratz
2016-04-03 13:58 ` Phillip Lord
2016-04-03 14:36 ` Andreas Schwab
2016-04-03 18:46 ` Phillip Lord
2016-04-03 18:58 ` Eli Zaretskii
2016-04-03 19:33 ` Phillip Lord
2016-04-03 19:39 ` Eli Zaretskii
2016-04-03 20:11 ` Phillip Lord
2016-04-04 15:27 ` Eli Zaretskii
2016-04-04 22:12 ` Phillip Lord
2016-04-05 18:16 ` Achim Gratz
2016-04-08 8:22 ` Eli Zaretskii [this message]
2016-04-08 15:25 ` Phillip Lord
2016-04-10 20:30 ` Phillip Lord
2016-04-12 12:03 ` Phillip Lord
2016-04-12 15:20 ` Eli Zaretskii
2016-04-12 15:39 ` Glenn Morris
2016-04-12 16:34 ` Phillip Lord
2016-04-12 16:40 ` Eli Zaretskii
2016-04-12 18:08 ` John Wiegley
2020-08-15 4:11 ` Stefan Kangas
2016-04-04 15:42 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83oa9kjyqt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23203@debbugs.gnu.org \
--cc=phillip.lord@russet.org.uk \
--cc=stromeko@nexgo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).