From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24594: 24.5; `variable-pitch-mode': accept FACE arg instead of hardcoding the face Date: Mon, 03 Oct 2016 10:00:12 +0300 Message-ID: <83oa31q5mr.fsf@gnu.org> References: <587cb6c7-44f8-4546-91ee-264416c965d6@default> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1475478091 9066 195.159.176.226 (3 Oct 2016 07:01:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Oct 2016 07:01:31 +0000 (UTC) Cc: 24594@debbugs.gnu.org, clement.pit@gmail.com To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 03 09:01:26 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxFU-0000YZ-8i for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Oct 2016 09:01:16 +0200 Original-Received: from localhost ([::1]:34112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqxFS-0002Gn-QK for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Oct 2016 03:01:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqxFK-0002Gg-W3 for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2016 03:01:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqxFG-00053S-Qj for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2016 03:01:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqxFG-00053M-N7 for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2016 03:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bqxFG-0008BS-90 for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2016 03:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Oct 2016 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24594 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24594-submit@debbugs.gnu.org id=B24594.147547801528171 (code B ref 24594); Mon, 03 Oct 2016 07:01:02 +0000 Original-Received: (at 24594) by debbugs.gnu.org; 3 Oct 2016 07:00:15 +0000 Original-Received: from localhost ([127.0.0.1]:42462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxEV-0007KJ-DF for submit@debbugs.gnu.org; Mon, 03 Oct 2016 03:00:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqxET-0007K0-NG for 24594@debbugs.gnu.org; Mon, 03 Oct 2016 03:00:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqxEL-0004nY-GY for 24594@debbugs.gnu.org; Mon, 03 Oct 2016 03:00:08 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqxEL-0004n2-EJ; Mon, 03 Oct 2016 03:00:05 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4968 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bqxEH-0007EX-ED; Mon, 03 Oct 2016 03:00:02 -0400 In-reply-to: <587cb6c7-44f8-4546-91ee-264416c965d6@default> (message from Drew Adams on Sun, 2 Oct 2016 20:48:19 -0700 (PDT)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123940 Archived-At: > Date: Sun, 2 Oct 2016 20:48:19 -0700 (PDT) > From: Drew Adams > > > > See http://emacs.stackexchange.com/a/27527/105: the user wants to use a > > > different face from face `variable-pitch'. That seems reasonable. > > > > That's not how I read it. I think they just want to change the look of > > Emacs after invoking variable-pitch-mode, and customizing the variable-pitch > > face seems like the right approach for that. > > The question as posed is ambiguous, but it specifically asks how to use a different face. No, he asks how to use a different _font_, and customizing the face (as you have suggested there) is the way to achieve that. > > > Please consider adding an optional FACE argument, defaulting to face > > > `variable-pitch'. > > > > I don't really see why the function should be called variable-pitch-mode any > > more. Maybe select-buffer-face? IIUC this wouldn't have anything to do with > > variable pitches any more, except for the default value, maybe? > > Agreed. Unless there is some particular use for limiting the accepted FACE to variable-pitch faces. In that case, additional logic/control would be needed. We already have buffer-face-mode. > Was there some particular reason that a mode was written specifically for variable-pitch (whether the face `variable-pitch' or variable-pitch faces in general), rather than providing a mode for any face? If not then agreed: a name change would be appropriate. The variable-pitch face is a very general face: it stands for a face using any variable-pitch font, of which there are gazillions.