unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
Cc: 27530@debbugs.gnu.org
Subject: bug#27530: patch to cut and copy secondary
Date: Wed, 20 Sep 2017 10:55:33 +0300	[thread overview]
Message-ID: <83o9q5g5xm.fsf@gnu.org> (raw)
In-Reply-To: <63B07AE9-1836-4EC5-8913-2D03249B9847@misasa.okayama-u.ac.jp> (message from Tak Kunihiro on Mon, 11 Sep 2017 11:03:58 +0900)

> From: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
> Date: Mon, 11 Sep 2017 11:03:58 +0900
> Cc: Kunihiro Tak <tkk@misasa.okayama-u.ac.jp>,
>  27530@debbugs.gnu.org
> 
> I am sending a patch relative to lisp/mouse.el to let user to
> set beginning and end of the region from those of the secondary
> selection.  I hope this meets your comments and please revise
> when it’s not good!

Thanks.  A few minor comments below.

> +(defun secondary-selection-exist-p ()
> +  "Return if there is the secondary selection in current buffer."
> +  (memq mouse-secondary-overlay (overlays-in (point-min) (point-max))))
> +
> +(defun secondary-selection-to-region ()
> +  "Set beginning and end of the region to those of the secondary selection.
> +This works when the secondary selection exists and the region
> +does not exist in current buffer.  The secondary selection will
> +be deleted afterward."

The doc string should describe where we put point and mark as result
of this.

> +  (when (and (not (region-active-p))
> +             (secondary-selection-exist-p))
> +    (let* ((beg (overlay-start mouse-secondary-overlay))
> +           (end (overlay-end mouse-secondary-overlay))
> +           ;; Restore point to whichever closer.
> +           (is-point-front (< (point) (/ (+ beg end) 2))))
> +      (push-mark (if is-point-front end beg) t t)
> +      (goto-char (if is-point-front beg end)))

Is it perhaps better to always put point at the end and mark at the
beginning of the overlay?  The heuristic seems to be complicating
matters for applications, which will have to perform the same
calculations to know in advance where point will be.

> +(defun secondary-selection-from-region ()
> +  "Set beginning and end of the secondary selection to those of the region."

This doc string should tell what happens if there's no active region.

Please also add a NEWS entry.





  reply	other threads:[~2017-09-20  7:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 12:43 bug#27530: patch to cut and copy secondary Tak Kunihiro
2017-06-29 13:41 ` Drew Adams
2017-07-01  0:45   ` Tak Kunihiro
2017-08-01  1:35     ` Tak Kunihiro
2017-09-05  3:11 ` Tak Kunihiro
2017-09-05  7:51   ` Robert Pluim
2017-09-05  9:25     ` Tak Kunihiro
2017-09-05  9:32       ` Robert Pluim
2017-09-05 12:22         ` Tak Kunihiro
2017-09-05 13:53       ` Drew Adams
2017-09-05 23:17         ` Tak Kunihiro
2017-09-06  0:29           ` Drew Adams
2017-09-05 15:08   ` Eli Zaretskii
2017-09-05 23:06     ` Tak Kunihiro
2017-09-06  2:33       ` Eli Zaretskii
2017-09-06  3:42         ` Tak Kunihiro
2017-09-06 16:04           ` Eli Zaretskii
2017-09-07 12:35             ` Tak Kunihiro
2017-09-07 19:11               ` Eli Zaretskii
2017-09-07 23:02                 ` Tak Kunihiro
2017-09-08  8:27                   ` Eli Zaretskii
2017-09-10  3:01                     ` Tak Kunihiro
2017-09-11  2:03                       ` Tak Kunihiro
2017-09-20  7:55                         ` Eli Zaretskii [this message]
2017-09-20 12:39                           ` Tak Kunihiro
2017-09-21  8:32                             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o9q5g5xm.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=27530@debbugs.gnu.org \
    --cc=tkk@misasa.okayama-u.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).