From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren Date: Sat, 13 Jan 2018 10:46:27 +0200 Message-ID: <83o9ly16zg.fsf@gnu.org> References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> <87o9mchc6k.fsf@mbork.pl> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1515833118 30957 195.159.176.226 (13 Jan 2018 08:45:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 13 Jan 2018 08:45:18 +0000 (UTC) Cc: 20871@debbugs.gnu.org To: Marcin Borkowski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 13 09:45:14 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaHR4-0007JV-AI for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jan 2018 09:45:06 +0100 Original-Received: from localhost ([::1]:50550 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaHT3-0001Fx-Uv for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jan 2018 03:47:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaHSx-0001FD-6G for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 03:47:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eaHSw-0000ko-7S for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 03:47:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eaHSw-0000kg-3j for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 03:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eaHSv-0004kG-Q5 for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2018 03:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jan 2018 08:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20871-submit@debbugs.gnu.org id=B20871.151583321818230 (code B ref 20871); Sat, 13 Jan 2018 08:47:01 +0000 Original-Received: (at 20871) by debbugs.gnu.org; 13 Jan 2018 08:46:58 +0000 Original-Received: from localhost ([127.0.0.1]:54359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaHSr-0004jy-Lb for submit@debbugs.gnu.org; Sat, 13 Jan 2018 03:46:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaHSq-0004jj-Ed for 20871@debbugs.gnu.org; Sat, 13 Jan 2018 03:46:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eaHSg-0000ZZ-S0 for 20871@debbugs.gnu.org; Sat, 13 Jan 2018 03:46:51 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaHSg-0000ZN-Nx; Sat, 13 Jan 2018 03:46:46 -0500 Original-Received: from [176.228.60.248] (port=4832 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eaHSg-0001Me-6X; Sat, 13 Jan 2018 03:46:46 -0500 In-reply-to: <87o9mchc6k.fsf@mbork.pl> (message from Marcin Borkowski on Tue, 02 Jan 2018 09:55:47 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142116 Archived-At: > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Tue, 02 Jan 2018 09:55:47 +0100 > > >> Where should I put the tests? > >> I expected something in e.g. test/lisp/textmodes/fill.el, but there's > >> nothing like that there. > > > > If the file doesn't exist, create it. > > > >> Also, should I test only my function, or filling with it, or both? > > > > I think filling with your function is the most important thing to > > test. > > > > Thanks. > > So that's what I did (see commit 1ad94a126b on branch fix/bug-20871, > http://git.savannah.gnu.org/cgit/emacs.git/log/?h=fix/bug-20871). Is > that ok? Yes. > I admit that these tests are rather simplistic, and I'm still > not sure about my commit message. I think this is ready to be installed, and if there are issues with commit messages, we will deal with them when installing. So please post the full patch for this issue, and let's take it from there. Thanks.