From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30215: Visiting files from zip archives should not modify directory time Date: Thu, 25 Jan 2018 05:30:19 +0200 Message-ID: <83o9limx84.fsf@gnu.org> References: <87mv157e8f.fsf@mail.linkov.net> <83h8rco7cg.fsf@gnu.org> <87tvvc8ds1.fsf@mail.linkov.net> <83zi53m6za.fsf@gnu.org> <87efmfuegl.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1516850987 2450 195.159.176.226 (25 Jan 2018 03:29:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 25 Jan 2018 03:29:47 +0000 (UTC) Cc: 30215@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 25 04:29:42 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeYDr-0006hz-Mk for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jan 2018 04:29:07 +0100 Original-Received: from localhost ([::1]:38885 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeYFr-0002hN-Vl for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jan 2018 22:31:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeYFl-0002hA-Nd for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 22:31:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeYFi-00017w-Jf for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 22:31:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33706) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eeYFi-00017H-GO for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 22:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eeYFi-00083T-Ap for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 22:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2018 03:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30215-submit@debbugs.gnu.org id=B30215.151685103530919 (code B ref 30215); Thu, 25 Jan 2018 03:31:02 +0000 Original-Received: (at 30215) by debbugs.gnu.org; 25 Jan 2018 03:30:35 +0000 Original-Received: from localhost ([127.0.0.1]:41603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeYFH-00082d-7N for submit@debbugs.gnu.org; Wed, 24 Jan 2018 22:30:35 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeYFF-00082R-Ki for 30215@debbugs.gnu.org; Wed, 24 Jan 2018 22:30:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeYF7-0000V1-9s for 30215@debbugs.gnu.org; Wed, 24 Jan 2018 22:30:28 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeYF7-0000Ut-5C; Wed, 24 Jan 2018 22:30:25 -0500 Original-Received: from [176.228.60.248] (port=3361 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eeYF6-0005BD-LZ; Wed, 24 Jan 2018 22:30:25 -0500 In-reply-to: <87efmfuegl.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 24 Jan 2018 23:36:10 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142497 Archived-At: > From: Juri Linkov > Cc: 30215@debbugs.gnu.org > Date: Wed, 24 Jan 2018 23:36:10 +0200 > > > If that's the problem, then I think it would be cleaner to disable > > creation of lock files and backup files by less subtle means -- by > > let-binding create-lockfiles and make-backup-files. Doing that by > > leaving buffer-file-truename at nil leaves the code less clear IMO, > > and relies on assumptions that might not hold at some future point. > > Thanks for the suggestion, this is better indeed: > > diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el > index adb3669..4fe1b03 100644 > --- a/lisp/arc-mode.el > +++ b/lisp/arc-mode.el > @@ -807,7 +807,7 @@ archive-summarize > Optional argument SHUT-UP, if non-nil, means don't print messages > when parsing the archive." > (widen) > - (let ((buffer-file-truename nil) ; avoid changing dir mtime by lock_file > + (let ((create-lockfiles nil) ; avoid changing dir mtime by lock_file This LGTM, but wasn't the problem also with creation of a backup file?