unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#30834: 27.0.50; posn-at-point and display-line-numbers-mode
@ 2018-03-16 10:45 Sébastien Chapuis
  2018-03-16 15:34 ` Andreas Röhler
  2018-03-16 17:17 ` Eli Zaretskii
  0 siblings, 2 replies; 7+ messages in thread
From: Sébastien Chapuis @ 2018-03-16 10:45 UTC (permalink / raw)
  To: 30834

Hi,

When display-line-numbers-mode is on and the (point) is on the
beginning of line, posn-at-point returns a wrong value.

Reproducible in emacs -Q:

```
(save-excursion
  (message "Without display-line-numbers:")
  (display-line-numbers-mode -1)
  (goto-char (line-beginning-position))
  (message "column 0: %s" (car (nth 2 (posn-at-point))))
  (forward-char)
  (message "column 1: %s" (car (nth 2 (posn-at-point))))
  (message "With display-line-numbers:")
  (display-line-numbers-mode)
  (goto-char (line-beginning-position))
  (message "column 0: %s" (car (nth 2 (posn-at-point))))
  (forward-char)
  (message "column 1: %s" (car (nth 2 (posn-at-point))))
  )
```

Output:
```
Without display-line-numbers:
column 0: 0
column 1: 19
With display-line-numbers:
column 0: 0
column 1: 114
```

On the bol, it returns zero but it should return (- 114 19)


In GNU Emacs 27.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.22.26)
 of 2018-03-13 built on XPS13
Repository revision: ae80854e9a9f8f6733870b5b5a88467867dceb6c
Windowing system distributor 'Fedora Project', version 11.0.11906000
System Description: Fedora 27 (Twenty Seven)

Configured using:
 'configure --prefix=/opt/emacs-git --with-modules --with-xwidgets
 --with-imagemagick CC=clang'

--
Sebastien Chapuis





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#30834: 27.0.50; posn-at-point and display-line-numbers-mode
  2018-03-16 10:45 bug#30834: 27.0.50; posn-at-point and display-line-numbers-mode Sébastien Chapuis
@ 2018-03-16 15:34 ` Andreas Röhler
  2018-03-16 16:19   ` Sebastien Chapuis
  2018-03-16 17:17 ` Eli Zaretskii
  1 sibling, 1 reply; 7+ messages in thread
From: Andreas Röhler @ 2018-03-16 15:34 UTC (permalink / raw)
  To: 30834

On 16.03.2018 11:45, Sébastien Chapuis wrote:
> Hi,
> 
> When display-line-numbers-mode is on and the (point) is on the
> beginning of line, posn-at-point returns a wrong value.
> 
> Reproducible in emacs -Q:
> 
> ```
> (save-excursion
>    (message "Without display-line-numbers:")
>    (display-line-numbers-mode -1)
>    (goto-char (line-beginning-position))
>    (message "column 0: %s" (car (nth 2 (posn-at-point))))
>    (forward-char)
>    (message "column 1: %s" (car (nth 2 (posn-at-point))))
>    (message "With display-line-numbers:")
>    (display-line-numbers-mode)
>    (goto-char (line-beginning-position))
>    (message "column 0: %s" (car (nth 2 (posn-at-point))))
>    (forward-char)
>    (message "column 1: %s" (car (nth 2 (posn-at-point))))
>    )
> ```
> 
> Output:
> ```
> Without display-line-numbers:
> column 0: 0
> column 1: 19
> With display-line-numbers:
> column 0: 0
> column 1: 114
> ```
> 
> On the bol, it returns zero but it should return (- 114 19)
> 
> 
> In GNU Emacs 27.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.22.26)
>   of 2018-03-13 built on XPS13
> Repository revision: ae80854e9a9f8f6733870b5b5a88467867dceb6c
> Windowing system distributor 'Fedora Project', version 11.0.11906000
> System Description: Fedora 27 (Twenty Seven)
> 
> Configured using:
>   'configure --prefix=/opt/emacs-git --with-modules --with-xwidgets
>   --with-imagemagick CC=clang'
> 
> --
> Sebastien Chapuis
> 
> 
> 

In use here:

(defun ar-count-lines (&optional beg end)
   "Count lines in accessible part of buffer.

See http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7115"
   (interactive)
   (let ((beg (or beg (point-min)))
	(end (or end (point)))
	erg)
     (if (bolp)
	(setq erg (1+ (count-lines beg end)))
       (setq erg (count-lines beg end)))
     (when (called-interactively-p 'any) (message "%s" erg))
     erg))






^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#30834: 27.0.50; posn-at-point and display-line-numbers-mode
  2018-03-16 15:34 ` Andreas Röhler
@ 2018-03-16 16:19   ` Sebastien Chapuis
  2018-03-16 21:41     ` Andreas Röhler
  0 siblings, 1 reply; 7+ messages in thread
From: Sebastien Chapuis @ 2018-03-16 16:19 UTC (permalink / raw)
  To: Andreas Röhler; +Cc: 30834


> In use here:
>
> (defun ar-count-lines (&optional beg end)
>   "Count lines in accessible part of buffer.
>
> See http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7115"
>   (interactive)
>   (let ((beg (or beg (point-min)))
> 	(end (or end (point)))
> 	erg)
>     (if (bolp)
> 	(setq erg (1+ (count-lines beg end)))
>       (setq erg (count-lines beg end)))
>     (when (called-interactively-p 'any) (message "%s" erg))
>     erg))

Sorry, I forgot to mention that the interesting value is the X position.
Is it still related to count-lines ?

--
Sebastien Chapuis





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#30834: 27.0.50; posn-at-point and display-line-numbers-mode
  2018-03-16 10:45 bug#30834: 27.0.50; posn-at-point and display-line-numbers-mode Sébastien Chapuis
  2018-03-16 15:34 ` Andreas Röhler
@ 2018-03-16 17:17 ` Eli Zaretskii
  2018-03-17 12:59   ` Sebastien Chapuis
  1 sibling, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2018-03-16 17:17 UTC (permalink / raw)
  To: Sébastien Chapuis; +Cc: 30834

> From: Sébastien Chapuis <sebastien@chapu.is>
> Date: Fri, 16 Mar 2018 11:45:43 +0100
> 
> When display-line-numbers-mode is on and the (point) is on the
> beginning of line, posn-at-point returns a wrong value.

Thanks, should be fixed now on the master branch.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#30834: 27.0.50; posn-at-point and display-line-numbers-mode
  2018-03-16 16:19   ` Sebastien Chapuis
@ 2018-03-16 21:41     ` Andreas Röhler
  0 siblings, 0 replies; 7+ messages in thread
From: Andreas Röhler @ 2018-03-16 21:41 UTC (permalink / raw)
  To: Sebastien Chapuis; +Cc: 30834

On 16.03.2018 17:19, Sebastien Chapuis wrote:
> 
>> In use here:
>>
>> (defun ar-count-lines (&optional beg end)
>>    "Count lines in accessible part of buffer.
>>
>> See http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7115"
>>    (interactive)
>>    (let ((beg (or beg (point-min)))
>> 	(end (or end (point)))
>> 	erg)
>>      (if (bolp)
>> 	(setq erg (1+ (count-lines beg end)))
>>        (setq erg (count-lines beg end)))
>>      (when (called-interactively-p 'any) (message "%s" erg))
>>      erg))
> 
> Sorry, I forgot to mention that the interesting value is the X position.
> Is it still related to count-lines ?
> 
> --
> Sebastien Chapuis
> 

Sorry, my fault. Referred to a bug in count-lines, which occurs at BOL.

As its docu says, the return value may differ: "but can be one more if 
START is not equal to END and the greater of them is not at the start of 
a line."

Seems unrelated here.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#30834: 27.0.50; posn-at-point and display-line-numbers-mode
  2018-03-16 17:17 ` Eli Zaretskii
@ 2018-03-17 12:59   ` Sebastien Chapuis
  2018-03-17 13:42     ` Eli Zaretskii
  0 siblings, 1 reply; 7+ messages in thread
From: Sebastien Chapuis @ 2018-03-17 12:59 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 30834


Eli Zaretskii writes:

>> From: Sébastien Chapuis <sebastien@chapu.is>
>> Date: Fri, 16 Mar 2018 11:45:43 +0100
>>
>> When display-line-numbers-mode is on and the (point) is on the
>> beginning of line, posn-at-point returns a wrong value.
>
> Thanks, should be fixed now on the master branch.

Thanks, it works now.

--
Sebastien Chapuis





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#30834: 27.0.50; posn-at-point and display-line-numbers-mode
  2018-03-17 12:59   ` Sebastien Chapuis
@ 2018-03-17 13:42     ` Eli Zaretskii
  0 siblings, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2018-03-17 13:42 UTC (permalink / raw)
  To: Sebastien Chapuis; +Cc: 30834-done

> From: Sebastien Chapuis <sebastien@chapu.is>
> Cc: 30834@debbugs.gnu.org
> Date: Sat, 17 Mar 2018 13:59:10 +0100
> 
> 
> Eli Zaretskii writes:
> 
> >> From: Sébastien Chapuis <sebastien@chapu.is>
> >> Date: Fri, 16 Mar 2018 11:45:43 +0100
> >>
> >> When display-line-numbers-mode is on and the (point) is on the
> >> beginning of line, posn-at-point returns a wrong value.
> >
> > Thanks, should be fixed now on the master branch.
> 
> Thanks, it works now.

OK, thanks for testing.  I'm therefore closing the bug report.





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-03-17 13:42 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-16 10:45 bug#30834: 27.0.50; posn-at-point and display-line-numbers-mode Sébastien Chapuis
2018-03-16 15:34 ` Andreas Röhler
2018-03-16 16:19   ` Sebastien Chapuis
2018-03-16 21:41     ` Andreas Röhler
2018-03-16 17:17 ` Eli Zaretskii
2018-03-17 12:59   ` Sebastien Chapuis
2018-03-17 13:42     ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).