unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 32637@debbugs.gnu.org
Subject: bug#32637: 27.0.50; window-size-change-functions not run from local hook
Date: Sun, 09 Sep 2018 09:03:20 +0300	[thread overview]
Message-ID: <83o9d7qkbb.fsf@gnu.org> (raw)
In-Reply-To: <87zhwrzgp8.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 09 Sep 2018 02:56:35 +0300)

> From: Juri Linkov <juri@linkov.net>
> Date: Sun, 09 Sep 2018 02:56:35 +0300
> Cc: 32637@debbugs.gnu.org
> 
> > I meant that running 'window-size-change-functions' in a buffer-local
> > fashion when no window showing that buffer has changed its size might
> > be misleading.
> 
> window-size-change-functions calling code could detect if a window with
> a buffer-local hook changed its size, and not to call its hook in this
> case.  This would be even better than using global hook where you can't
> implement such optimization.

This might be very hard to implement, given how these hooks are called
today.  In fact, it might be impossible to implement without changing
the strategy of running this hook, and that could very well change the
semantics of the hook, and break some existing packages that use them.

> > But put a buffer-local function on 'window-configuration-change-hook'
> > and show the buffer in two windows.  The function gets called twice
> > with the respective window selected.  So if we implemented
> > 'window-size-change-functions' in the same way as you suggested
> > earlier, you would "find all Man windows on the frame to compare their
> > sizes and reformat the buffer with the minimim width from all its
> > windows" twice.  How would you deal with that?
> 
> window-size-change-functions calling code could call it only once
> for every frame, even if the same buffer is displayed in multiple
> windows.

AFAIK, window-size-change-functions is already called once per frame,
so I'm not sure what you are saying here.





  reply	other threads:[~2018-09-09  6:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 21:03 bug#32637: 27.0.50; window-size-change-functions not run from local hook Juri Linkov
2018-09-05  7:47 ` martin rudalics
2018-09-05 15:26   ` Eli Zaretskii
2018-09-05 21:56     ` Juri Linkov
2018-09-06  2:35       ` Eli Zaretskii
2018-09-06 22:17         ` Juri Linkov
2018-09-05 21:54   ` Juri Linkov
2018-09-06  7:05     ` martin rudalics
2018-09-06 22:06       ` Juri Linkov
2018-09-07  7:31         ` martin rudalics
2018-09-08 23:56           ` Juri Linkov
2018-09-09  6:03             ` Eli Zaretskii [this message]
2018-09-09  8:40             ` martin rudalics
2018-09-09 15:59               ` Eli Zaretskii
2018-09-10  8:29                 ` martin rudalics
2018-09-09 16:17               ` Juri Linkov
2018-09-10  8:29                 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o9d7qkbb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=32637@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).