From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 23:03:15 +0300 Message-ID: <83o8ygcvb0.fsf@gnu.org> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <83y2xkcyu9.fsf@gnu.org> <87o8yg5v80.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="255633"; mail-complaints-to="usenet@blaine.gmane.org" Cc: andreyorst@gmail.com, spacibba@aol.com, 37774@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 22:04:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKpWm-0014O0-EQ for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 22:04:12 +0200 Original-Received: from localhost ([::1]:47696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKpWl-0004zG-8Y for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 16:04:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37929) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKpWf-0004we-LG for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:04:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKpWd-0008OU-MG for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:04:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37797) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKpWc-0008OH-Pp for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKpWc-0001eN-J8 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 20:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15712562216316 (code B ref 37774); Wed, 16 Oct 2019 20:04:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 20:03:41 +0000 Original-Received: from localhost ([127.0.0.1]:46618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKpWH-0001do-Dv for submit@debbugs.gnu.org; Wed, 16 Oct 2019 16:03:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKpWG-0001dc-8Y for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 16:03:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iKpWA-0007zc-Tp; Wed, 16 Oct 2019 16:03:34 -0400 Original-Received: from [176.228.60.248] (port=4857 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iKpWA-0000bA-9m; Wed, 16 Oct 2019 16:03:34 -0400 In-reply-to: <87o8yg5v80.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 16 Oct 2019 22:46:55 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169490 Archived-At: > From: Juri Linkov > Cc: spacibba@aol.com, andreyorst@gmail.com, 37774@debbugs.gnu.org > Date: Wed, 16 Oct 2019 22:46:55 +0300 > > > I'm not sure I understand: the region face is defined to be extended > > beyond EOL. How does custom-set-faces enter this picture, and why did > > you need to do anything about the customized faces? > > The region face customized long ago in the init file > has no ':extend t' face attribute, e.g. > > (custom-set-faces > '(region ((((class color) (background light)) (:background "gray90")))) So maybe we should modify custom-set-faces to preserve the :extend attribute? Would that solve the problem? > >> Soon I tired fixing their customizations one by one manually, > > > > Which other faces needed to be "fixed", how, and why? > > All diff faces and faces that have a distinct background color > like 'comint-highlight-input' (should extend to window edge > to help locating visually the command line in shell buffers), > 'org-block' (because it highlights code blocks), 'xref-file-header' > for the same reason as diff faces, i.e. faces that highlights blocks. I don't think I agree. I'm not convinced by the reasons, and I find the new appearance not worse (and sometimes better) than the old. I think the objections are mostly because of the surprising new appearance. > All complaints are only about extending background colors to EOL. We've been discussing this only for a day. So whether all the complaints are about the background remains to be seen. It could be because most of our faces only specify colors, for example. > >> This screenshot demonstrates how badly broken these blocks are now > >> in diff-mode that it makes harder to read diffs: > > > > I'm sorry, but I don't see why it is broken or hard to read. > > Because there is no distinctive rectangular header anymore, > and no diff hunk blocks. Sorry, I don't think I follow: how do you mean there's no distinctive header and no diff hunk blocks? I see them quite clearly. > >> Ideally to be more nice-looking, background colors in such faces should be > >> extended to the column defined e.g. by display-fill-column-indicator-column. > > > > That would be ugly if the line's text extends beyond the fill-column, > > no? Also, it would look even uglier with variable-pitch fonts. > > Extending to the fill-column could be an optional feature. But above you mention it as the default. If it's an option, then it cannot be a solution to the problems we are discussing.