From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Sat, 07 Dec 2019 21:14:04 +0200 Message-ID: <83o8wkdk3n.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> <83ftiasfdm.fsf@gnu.org> <83lfrulmva.fsf@gnu.org> <76a012f5-8cdd-75d5-322e-a453a612c655@yandex.ru> <83immxjs6q.fsf@gnu.org> <993b2f9c-6052-e791-3d3b-26d5fedd7d12@yandex.ru> <835ziuixke.fsf@gnu.org> <9c4768a5-ecce-68ce-c612-a001b2f6784d@yandex.ru> <8336dxh1ge.fsf@gnu.org> <6c68ceed-156c-a6f2-bf0f-21d7e9eb5692@yandex.ru> <831rthgy3u.fsf@gnu.org> <83o8wkfu63.fsf@gnu.org> <83r21gdnun.fsf@gnu.org> <839f1185-fc0c-0e8b-29fd-5431fb71ab2e@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="246559"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 08 03:30:34 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idmL7-0011tV-8Y for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Dec 2019 03:30:29 +0100 Original-Received: from localhost ([::1]:54824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idmL6-0001je-35 for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Dec 2019 21:30:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58585) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idmKo-0001hL-6N for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 21:30:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idmKk-0004Hm-Fa for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 21:30:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43992) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idmKg-0004FA-VQ for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 21:30:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idmKg-0003oL-R7 for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 21:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2019 02:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157577218514553 (code B ref 37774); Sun, 08 Dec 2019 02:30:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 8 Dec 2019 02:29:45 +0000 Original-Received: from localhost ([127.0.0.1]:49963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idmKP-0003me-4i for submit@debbugs.gnu.org; Sat, 07 Dec 2019 21:29:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idmKM-0003mQ-V0 for 37774@debbugs.gnu.org; Sat, 07 Dec 2019 21:29:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1idfX8-0002mY-CS; Sat, 07 Dec 2019 14:14:26 -0500 Original-Received: from [176.228.60.248] (port=3488 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1idfX7-0004ck-OF; Sat, 07 Dec 2019 14:14:26 -0500 In-reply-to: <839f1185-fc0c-0e8b-29fd-5431fb71ab2e@yandex.ru> (message from Dmitry Gutov on Sat, 7 Dec 2019 20:55:31 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172996 Archived-At: > Cc: 37774@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > Date: Sat, 7 Dec 2019 20:55:31 +0200 > > > We are not trying to change the core behavior, we are trying to change > > how themes define faces, in a way that makes the :extend attribute be > > implicitly inherited from the default spec of the face to the face > > after theme's customizations. > > We're really trying to change how a face's attributes are calculated > based on its default spec, as well as enabled themes. There are > different callers to face-spec-recalc because different user features > require that re-calculation. > > > All I want is to make sure no other > > caller of face-spec-recalc, one that has nothing to do with themes > > defining faces, picks up the change, because that would be unintended. > > If you consider this incorrect or unjustified, please explain why. > > Here's some examples: > > enable-theme needs that recalculation because a different set of themes > is now in effect, and face attributes need to be updated. > > face-set-after-frame-default needs that because a frame's parameters can > affect how faces look as well. > > frame-set-background-mode needs that to update how face specs are > interpreted given the changed background mode. > > All of these affect how a face spec is evaluated, which affects how > theme specs and user specs apply to the face. Which should be able to > change which spec the value of :extend is taken from. > > Or, to look at it from another direction: if we create a special > different version of face-spec-recalc purely for custom-theme-set-faces, > and face-set-after-frame-default wouldn't use it, whatever changed logic > we implement wouldn't apply to new frames. Our goal is to allow themes "inherit" the :extend attribute without having to specify it in their face specs, unlike with other attributes. That's the only goal; we don't want :extend to behave differently from other face attributes in any other context. If you are saying that we cannot make this change apply only to face definitions by themes, then it means we don't really understand what we could break here, and then I don't think I want this change in Emacs 27. Sorry, it's too risky. (I thought cus-face.el stores information in symbol properties that enables it to apply the face attributes in a special way. But I don't consider myself an expert on these matters, so if you say we cannot differentiate between general face definition and what themes do, so be it.) > I'm not sure :extend is always the last pair in the list. > > ELISP> (plist-member '(:a 1 :b 2 :c 3) :b) > (:b 2 :c 3) You are right, your code is more correct.