From: Eli Zaretskii <eliz@gnu.org>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: 38812@debbugs.gnu.org
Subject: bug#38812: 28.0.50; Custom: Problem with reverting some session's customizations
Date: Tue, 31 Dec 2019 18:04:52 +0200 [thread overview]
Message-ID: <83o8volbvf.fsf@gnu.org> (raw)
In-Reply-To: <CABczVweDUwsFWHPPZ7XVjGHOzePaFp-jtEpfgE4zydALARJi_Q@mail.gmail.com> (message from Mauro Aranda on Tue, 31 Dec 2019 11:22:27 -0300)
> From: Mauro Aranda <maurooaranda@gmail.com>
> Date: Tue, 31 Dec 2019 11:22:27 -0300
>
> * lisp/custom.el (custom-variable-theme-value): Return a new list with
> the value of variable, so the values of the properties 'theme-value
> and 'saved-value are not shared. (Bug#38812)
> ---
> lisp/custom.el | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/custom.el b/lisp/custom.el
> index 26bdaae..e9bb0d3 100644
> --- a/lisp/custom.el
> +++ b/lisp/custom.el
> @@ -1483,8 +1483,8 @@ custom-variable-theme-value
>
> This function returns nil if no custom theme specifies a value for VARIABLE."
> (let ((theme-value (get variable 'theme-value)))
> - (if theme-value
> - (cdr (car theme-value)))))
> + (if theme-value ; ((THEME VALUE))
> + (list (cadar theme-value)))))
This will look strange without some comment explaining why we do this.
And I have a question is: isn't it better not to use setcar in
custom-push-theme instead?
next prev parent reply other threads:[~2019-12-31 16:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 14:11 bug#38812: 28.0.50; Custom: Problem with reverting some session's customizations Mauro Aranda
2019-12-31 14:22 ` Mauro Aranda
2019-12-31 16:04 ` Eli Zaretskii [this message]
2019-12-31 17:21 ` Mauro Aranda
2019-12-31 17:25 ` Eli Zaretskii
2019-12-31 17:38 ` Mauro Aranda
2020-01-01 17:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o8volbvf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=38812@debbugs.gnu.org \
--cc=maurooaranda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).