From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38966: 27.0.60; Assertion failure in set_cursor_from_row Date: Tue, 07 Jan 2020 18:01:07 +0200 Message-ID: <83o8vfcl30.fsf@gnu.org> References: <497636f5-1728-1e7e-b826-8310e2a6fe13@gmx.at> <83lfqkecc6.fsf@gnu.org> <12ea3c04-249a-96da-8c88-52dcb5ca8b66@gmx.at> <8336cse544.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="164791"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38966@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 07 17:02:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iorJ4-000dSw-LJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2020 17:02:10 +0100 Original-Received: from localhost ([::1]:52226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iorJ3-0007Td-G6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2020 11:02:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32923) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iorIx-0007S1-Re for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:02:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iorIw-0005xv-RN for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:02:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43096) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iorIw-0005xm-O5 for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iorIw-0002G6-LG for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2020 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38966 X-GNU-PR-Package: emacs Original-Received: via spool by 38966-submit@debbugs.gnu.org id=B38966.15784128668606 (code B ref 38966); Tue, 07 Jan 2020 16:02:02 +0000 Original-Received: (at 38966) by debbugs.gnu.org; 7 Jan 2020 16:01:06 +0000 Original-Received: from localhost ([127.0.0.1]:49069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iorI2-0002Ek-9m for submit@debbugs.gnu.org; Tue, 07 Jan 2020 11:01:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iorI0-0002E9-BO for 38966@debbugs.gnu.org; Tue, 07 Jan 2020 11:01:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iorHv-0005I6-5W; Tue, 07 Jan 2020 11:00:59 -0500 Original-Received: from [176.228.60.248] (port=1233 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iorHt-0005h7-2T; Tue, 07 Jan 2020 11:00:57 -0500 In-reply-to: (message from martin rudalics on Tue, 7 Jan 2020 10:52:18 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174309 Archived-At: > Cc: 38966-done@debbugs.gnu.org > From: martin rudalics > Date: Tue, 7 Jan 2020 10:52:18 +0100 > > > Why is such a window useful? > > Windows with one text line like that of the ediff control panel have > been in use for quite some time. They can also arise automatically, > for example, when fitting a one line completions window to its buffer. I thought we were talking about windows with zero lines of text. One text line is fine, and should not cause any trouble to the current display code. When testing my patch, I used your code to resized the window to a single 1-pixel high line of text, and saw no problems, including with displaying the cursor. If the use cases you have in mind can make do with one 1-pixel line of text, we will need no changes in the display engine at all to support that. > > All I'm saying is that making the display code prepared to deal with > > such windows might take more changes, and this would be a separate > > issue, suitable for master, not for the release branch. OK? > > Sure. My concerns are only that we should not preclude future changes > in this area when making changes on the release branch like adding new > assertions. To fix the present bug, for example, I would have simply > removed the offending assertion from set_cursor_from_row. Eventually, > we might want to show a cursor in a mode line, or scroll or wrap it. I think we should keep that assertion as long as we don't make the code DTRT with such text-less windows. That assertion only affects developers anyway. The right time for removing the assertion is when we modify the code to support windows with no text rows.