From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling Date: Mon, 10 Aug 2020 19:45:01 +0300 Message-ID: <83o8ni4fhu.fsf@gnu.org> References: <23640.9851.562972.730234@AGAME7.local> <875ztog7hx.fsf@panama> <87wom1otsw.fsf@panama> <87zh7267sy.fsf@gnus.org> <87pn7yo54t.fsf@panama> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30405"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 34315@debbugs.gnu.org, thunk2@arcor.de To: Ulf Jasper Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 10 18:46:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5Aw7-0007jq-0r for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 18:46:11 +0200 Original-Received: from localhost ([::1]:41020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5Aw5-0002p4-Vg for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 12:46:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5Avy-0002ow-Dl for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 12:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5Avy-0008F0-4l for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 12:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5Avy-0002v2-2N for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 12:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Aug 2020 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34315 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34315-submit@debbugs.gnu.org id=B34315.15970779279199 (code B ref 34315); Mon, 10 Aug 2020 16:46:02 +0000 Original-Received: (at 34315) by debbugs.gnu.org; 10 Aug 2020 16:45:27 +0000 Original-Received: from localhost ([127.0.0.1]:37354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5AvP-0002Nz-B2 for submit@debbugs.gnu.org; Mon, 10 Aug 2020 12:45:27 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5AvL-0002F2-6r for 34315@debbugs.gnu.org; Mon, 10 Aug 2020 12:45:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53810) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5AvE-000829-1E; Mon, 10 Aug 2020 12:45:16 -0400 Original-Received: from [176.228.60.248] (port=4561 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k5AvD-0002Mk-AP; Mon, 10 Aug 2020 12:45:15 -0400 In-Reply-To: <87pn7yo54t.fsf@panama> (message from Ulf Jasper on Mon, 10 Aug 2020 18:08:34 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184559 Archived-At: > From: Ulf Jasper > Cc: thunk2@arcor.de (Thomas Plass), 34315@debbugs.gnu.org > Date: Mon, 10 Aug 2020 18:08:34 +0200 > > IIRC the patch looked good insofar as it appeared to address only the > observed problem and to be properly documented and formatted although I > was not able to reproduce the problem. > > > But then the thread turned towards questions about daylight savings > > time handling in Windows, and the patch itself wasn't applied? > > Right, the patch was not applied. > > Eli pointed out that the root cause lies in the dst handling in > ms-windows (and not in newsticker). That makes the patch more of a > work-around than a fix. > > I admit that I am not very much inclined to check and apply the patch as > I do not have a ms-windows box to run tests on. > > Eli, what do you think? My comments were not about the patch (which I admit I don't really understand, as I don't use icalendar), but about the attempts to see what happens with time under different TZ settings. As for the patch, I've looked at it again now, and I don't think it's specific to MS-Windows, is it? If so, and if you think it's good, feel free to install. Thanks.