From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43973: 28.0.50; [NS] Two crashes on macOS Date: Sat, 24 Oct 2020 13:35:02 +0300 Message-ID: <83o8krhpyh.fsf@gnu.org> References: <20201013190946.GK60347@breton.holly.idiocy.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20737"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43973@debbugs.gnu.org, andreyk.mad@gmail.com To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 24 12:36:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWGuC-0005IA-Ku for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Oct 2020 12:36:12 +0200 Original-Received: from localhost ([::1]:44702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWGuB-0002EP-72 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Oct 2020 06:36:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWGu3-0002EE-6I for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 06:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWGu2-0005uv-8u for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 06:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWGu2-0000n3-5m for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 06:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Oct 2020 10:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43973 X-GNU-PR-Package: emacs Original-Received: via spool by 43973-submit@debbugs.gnu.org id=B43973.16035357242987 (code B ref 43973); Sat, 24 Oct 2020 10:36:02 +0000 Original-Received: (at 43973) by debbugs.gnu.org; 24 Oct 2020 10:35:24 +0000 Original-Received: from localhost ([127.0.0.1]:32815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWGtQ-0000m7-6K for submit@debbugs.gnu.org; Sat, 24 Oct 2020 06:35:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWGtM-0000lr-Ba for 43973@debbugs.gnu.org; Sat, 24 Oct 2020 06:35:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45266) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWGtG-0005Vz-I7; Sat, 24 Oct 2020 06:35:14 -0400 Original-Received: from [176.228.60.248] (port=2568 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kWGtF-0007Sw-Ti; Sat, 24 Oct 2020 06:35:14 -0400 In-Reply-To: <20201013190946.GK60347@breton.holly.idiocy.org> (message from Alan Third on Tue, 13 Oct 2020 20:09:46 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191413 Archived-At: > Date: Tue, 13 Oct 2020 20:09:46 +0100 > From: Alan Third > Cc: 43973@debbugs.gnu.org > > > The second one is not reproducible every time: > > > > 1. M-x tool-bar-mode > > 2. Evaluate > > (let ((params `((parent-frame . ,(selected-frame)) > > (undecorated . t)))) > > (dotimes (_z 100) > > (set-face-background 'internal-border "black" > > (make-frame params)))) > > 3. Move the frame > > I can replicate this one, every time. > > I'm not sure exactly what's going on, but it's resulting in face == > NULL, so > > modified src/nsterm.m > @@ -3048,6 +3048,9 @@ so some key presses (TAB) are swallowed by the system. */ > if (!face) > face = FRAME_DEFAULT_FACE (f); > > + if (!face) > + return; > + > ns_focus (f, &frame_rect, 1); > [ns_lookup_indexed_color (NS_FACE_BACKGROUND (face), f) set]; > for (int i = 0; i < 4 ; i++) > > > "fixes" it, but leaves Emacs in a bit of a strange state where I can > only see one frame and it's incredibly slow. Can you spot which code calls free_all_realized_faces in this case? We could either try to prevent that, or call recompute_basic_faces, then the behavior should be better, I think.