From: Eli Zaretskii <eliz@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: 43973@debbugs.gnu.org, andreyk.mad@gmail.com
Subject: bug#43973: 28.0.50; [NS] Two crashes on macOS
Date: Sat, 24 Oct 2020 13:35:02 +0300 [thread overview]
Message-ID: <83o8krhpyh.fsf@gnu.org> (raw)
In-Reply-To: <20201013190946.GK60347@breton.holly.idiocy.org> (message from Alan Third on Tue, 13 Oct 2020 20:09:46 +0100)
> Date: Tue, 13 Oct 2020 20:09:46 +0100
> From: Alan Third <alan@idiocy.org>
> Cc: 43973@debbugs.gnu.org
>
> > The second one is not reproducible every time:
> >
> > 1. M-x tool-bar-mode
> > 2. Evaluate
> > (let ((params `((parent-frame . ,(selected-frame))
> > (undecorated . t))))
> > (dotimes (_z 100)
> > (set-face-background 'internal-border "black"
> > (make-frame params))))
> > 3. Move the frame
>
> I can replicate this one, every time.
>
> I'm not sure exactly what's going on, but it's resulting in face ==
> NULL, so
>
> modified src/nsterm.m
> @@ -3048,6 +3048,9 @@ so some key presses (TAB) are swallowed by the system. */
> if (!face)
> face = FRAME_DEFAULT_FACE (f);
>
> + if (!face)
> + return;
> +
> ns_focus (f, &frame_rect, 1);
> [ns_lookup_indexed_color (NS_FACE_BACKGROUND (face), f) set];
> for (int i = 0; i < 4 ; i++)
>
>
> "fixes" it, but leaves Emacs in a bit of a strange state where I can
> only see one frame and it's incredibly slow.
Can you spot which code calls free_all_realized_faces in this case?
We could either try to prevent that, or call recompute_basic_faces,
then the behavior should be better, I think.
next prev parent reply other threads:[~2020-10-24 10:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 7:35 bug#43973: 28.0.50; [NS] Two crashes on macOS Andrii Kolomoiets
2020-10-13 13:00 ` Robert Pluim
2020-10-13 20:33 ` Alan Third
2020-10-14 10:46 ` Robert Pluim
2020-10-13 19:09 ` Alan Third
2020-10-14 8:07 ` Andrii Kolomoiets
2020-10-14 8:50 ` Andrii Kolomoiets
2020-10-24 10:35 ` Eli Zaretskii [this message]
2020-10-14 20:41 ` Alan Third
2020-10-14 21:01 ` Andrii Kolomoiets
2020-10-14 21:15 ` Alan Third
2020-10-14 21:33 ` Andrii Kolomoiets
2021-01-02 18:25 ` Alan Third
2021-01-02 22:03 ` Andrii Kolomoiets
2021-01-02 22:34 ` Alan Third
2020-10-24 1:37 ` Win Treese
2020-10-24 16:59 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o8krhpyh.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=43973@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=andreyk.mad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).