From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes Date: Fri, 30 Oct 2020 15:43:22 +0200 Message-ID: <83o8kjakxx.fsf@gnu.org> References: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8324"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 14635@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 14:44:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYUhN-00025H-VP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 14:44:09 +0100 Original-Received: from localhost ([::1]:44658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYUhM-0005u5-V3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 09:44:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYUhG-0005tl-59 for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 09:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYUhF-0003f0-Sw for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 09:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYUhF-0008Gh-RP for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 09:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 13:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 14635-submit@debbugs.gnu.org id=B14635.160406542731756 (code B ref 14635); Fri, 30 Oct 2020 13:44:01 +0000 Original-Received: (at 14635) by debbugs.gnu.org; 30 Oct 2020 13:43:47 +0000 Original-Received: from localhost ([127.0.0.1]:56709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUh1-0008G8-AP for submit@debbugs.gnu.org; Fri, 30 Oct 2020 09:43:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUgz-0008Fv-Vf for 14635@debbugs.gnu.org; Fri, 30 Oct 2020 09:43:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44515) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYUgu-0003dW-4A; Fri, 30 Oct 2020 09:43:40 -0400 Original-Received: from [176.228.60.248] (port=2828 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYUgt-0004hU-DT; Fri, 30 Oct 2020 09:43:39 -0400 In-Reply-To: (message from Mauro Aranda on Fri, 30 Oct 2020 10:35:33 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192105 Archived-At: > From: Mauro Aranda > Date: Fri, 30 Oct 2020 10:35:33 -0300 > Cc: 14635@debbugs.gnu.org > > For the default face, face-spec-reset-face only sets all attributes to > default values if (display-graphic-p frame) returns nil. So on a > graphical display, it never resets :family, :foundry, :width, :height, > :weight, :slant, :foreground and :background. That's because on GUI frames there's no real default for these attributes (unlike on a TTY where we inherit the colors of the terminal). So we simply _cannot_ reset the attributes like that, because there's nothing to reset to. E.g., unspecified-fg only has meaning on a TTY frame. > What would be the right way for face-spec-reset-face to reset all the > attributes of the default face to the default values, in a graphic > display? Doesn't customizing a face record the original value in some property of the face symbol? If so, reverting the customizations should use those recorded values, I think.