From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44794: 28.0.50; Frame creation broken with (tool-bar-mode -1) Date: Sun, 22 Nov 2020 20:39:20 +0200 Message-ID: <83o8jpw813.fsf@gnu.org> References: <838satxufx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25694"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, 44794@debbugs.gnu.org To: David Fussner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 22 19:40:38 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kguHu-0006aG-0g for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Nov 2020 19:40:38 +0100 Original-Received: from localhost ([::1]:44182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kguHs-0007um-SL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Nov 2020 13:40:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kguHK-0007uE-4w for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2020 13:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36724) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kguHJ-0006AO-TA for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2020 13:40:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kguHJ-0003wT-PY for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2020 13:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Nov 2020 18:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44794 X-GNU-PR-Package: emacs Original-Received: via spool by 44794-submit@debbugs.gnu.org id=B44794.160607037515111 (code B ref 44794); Sun, 22 Nov 2020 18:40:01 +0000 Original-Received: (at 44794) by debbugs.gnu.org; 22 Nov 2020 18:39:35 +0000 Original-Received: from localhost ([127.0.0.1]:48270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kguGt-0003vf-CN for submit@debbugs.gnu.org; Sun, 22 Nov 2020 13:39:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kguGr-0003vS-U9 for 44794@debbugs.gnu.org; Sun, 22 Nov 2020 13:39:34 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49374) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kguGm-0005xF-8v; Sun, 22 Nov 2020 13:39:28 -0500 Original-Received: from [176.228.60.248] (port=4695 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kguGl-0002Af-G4; Sun, 22 Nov 2020 13:39:28 -0500 In-Reply-To: (message from David Fussner on Sun, 22 Nov 2020 18:08:59 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193863 Archived-At: > From: David Fussner > Date: Sun, 22 Nov 2020 18:08:59 +0000 > Cc: Stefan Kangas , 44794@debbugs.gnu.org > > Strange that the issue just turned up after that commit, though. My > .emacs hasn't changed in quite a while. Is there anything I can do to > help debug this? With some guidance from you both I can run emacs > under gdb if that might produce useful information. I'd begin by establishing which of the two if/else branches of the offending code your Emacs takes: Lisp_Object system_name = Fsystem_name (); static char const title[] = "GNU Emacs"; if (STRINGP (system_name)) { static char const at[] = " at "; ptrdiff_t nbytes = sizeof (title) + sizeof (at); if (INT_ADD_WRAPV (nbytes, SBYTES (system_name), &nbytes)) memory_full (SIZE_MAX); dpyinfo->x_id_name = xmalloc (nbytes); sprintf (dpyinfo->x_id_name, "%s%s%s", title, at, SDATA (system_name)); } else { dpyinfo->x_id_name = xmalloc (sizeof (title)); strcpy (dpyinfo->x_id_name, title); }