From: Eli Zaretskii <eliz@gnu.org>
To: "J.P." <jp@neverwas.me>
Cc: 46342@debbugs.gnu.org
Subject: bug#46342: 28.0.50; socks-send-command munges IP address bytes to UTF-8
Date: Wed, 10 Feb 2021 18:04:56 +0200 [thread overview]
Message-ID: <83o8grj4d3.fsf@gnu.org> (raw)
In-Reply-To: <87ft24njud.fsf@neverwas.me> (jp@neverwas.me)
> From: "J.P." <jp@neverwas.me>
> Cc: 46342@debbugs.gnu.org
> Date: Wed, 10 Feb 2021 05:16:58 -0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > what kind of string can this ADDRESS be? My reading of RFC 1928 is
> > that it normally is an IP address, in which case encoding is not
> > relevant, as it's an ASCII string. But it can also be a domain, right?
>
> This patch only affects IP addresses, but I'm happy to look into the
> domain name form as well.
Then I don't understand why we need to worry about encoding. IP
addresses are pure ASCII strings, so they need no encoding whatsoever.
I guess I will have to ask you to back up and describe what problems
you saw with the original code, and show me the details of the strings
involved in that.
Thanks for the rest of your message, but I suggest that we limit
ourselves to IP addresses for the time being, and only go to non-ASCII
domains when we have the IP address use case figured out.
next prev parent reply other threads:[~2021-02-10 16:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 11:46 bug#46342: 28.0.50; socks-send-command munges IP address bytes to UTF-8 J.P.
2021-02-06 12:26 ` Eli Zaretskii
2021-02-06 14:19 ` J.P.
2021-02-06 15:15 ` Eli Zaretskii
2021-02-07 14:22 ` J.P.
2021-02-09 15:17 ` J.P.
2021-02-09 16:14 ` Eli Zaretskii
2021-02-10 13:16 ` J.P.
2021-02-10 16:04 ` Eli Zaretskii [this message]
2021-02-11 14:58 ` J.P.
2021-02-11 15:28 ` Eli Zaretskii
2021-02-12 14:30 ` J.P.
2021-02-12 15:04 ` Eli Zaretskii
2021-02-13 15:43 ` J.P.
2021-02-17 14:59 ` J.P.
2021-02-20 9:33 ` Eli Zaretskii
2021-02-20 10:13 ` J.P.
2021-02-20 11:08 ` Eli Zaretskii
2021-02-20 15:08 ` J.P.
2021-02-20 15:19 ` Eli Zaretskii
2021-02-20 10:41 ` J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o8grj4d3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=46342@debbugs.gnu.org \
--cc=jp@neverwas.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).