From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48264: [PATCH v3 12/15] Set buffer_defaults fields without a default to Qunbound Date: Fri, 07 May 2021 16:29:25 +0300 Message-ID: <83o8dmbrka.fsf@gnu.org> References: <877dkbsj9d.fsf@catern.com> <20210506213346.9730-13-sbaugh@catern.com> <83a6p6ddur.fsf@gnu.org> <87fsyyr87y.fsf@catern.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11025"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48264@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 15:34:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lf0cg-0002jR-OT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 15:34:30 +0200 Original-Received: from localhost ([::1]:43244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf0cf-00011m-R6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 09:34:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf0YO-0006fJ-Cq for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:30:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60599) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lf0YM-0003Ww-Ja for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lf0YM-0006o8-E0 for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48264 X-GNU-PR-Package: emacs Original-Received: via spool by 48264-submit@debbugs.gnu.org id=B48264.162039417826134 (code B ref 48264); Fri, 07 May 2021 13:30:02 +0000 Original-Received: (at 48264) by debbugs.gnu.org; 7 May 2021 13:29:38 +0000 Original-Received: from localhost ([127.0.0.1]:43911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf0Xy-0006nS-6U for submit@debbugs.gnu.org; Fri, 07 May 2021 09:29:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf0Xw-0006nM-JY for 48264@debbugs.gnu.org; Fri, 07 May 2021 09:29:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48000) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf0Xr-0003GU-8Q; Fri, 07 May 2021 09:29:31 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3868 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1lf0Xq-0001Jj-BL; Fri, 07 May 2021 09:29:30 -0400 In-Reply-To: <87fsyyr87y.fsf@catern.com> (message from Spencer Baugh on Fri, 07 May 2021 09:20:33 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205938 Archived-At: > From: Spencer Baugh > Cc: 48264@debbugs.gnu.org > Date: Fri, 07 May 2021 09:20:33 -0400 > > Eli Zaretskii writes: > >> From: Spencer Baugh > >> + if (!(offset == PER_BUFFER_VAR_OFFSET (syntax_table) > >> + || offset == PER_BUFFER_VAR_OFFSET (category_table))) > > > > Please add a comment here about these two exemptions. (And I cannot > > say that I like such kludges; why doe we need it?) > > The syntax_table and category_table fields in buffer_defaults are used > through Vstandard_syntax_table and Vstandard_category_table (which are > just aliases to the fields in buffer_defaults); the initialization for > syntax.c and category.c runs before buffer.c, so they're already set at > this point. I could reorder the initialization if you'd prefer that? > Or move the initialization into buffer.c? If it works to move init_buffer_once before init_syntax_once, I think that'd be much better.