From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable Date: Sat, 24 Jul 2021 20:39:22 +0300 Message-ID: <83o8ary5kl.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5559"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani To: 49723@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 24 19:40:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7LdH-0001HW-Vz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Jul 2021 19:40:15 +0200 Original-Received: from localhost ([::1]:49068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7LdH-00010K-26 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Jul 2021 13:40:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Ld4-0000zn-5M for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2021 13:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35340) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7Ld3-0005E0-UP for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2021 13:40:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7Ld3-0001ax-T2 for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2021 13:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jul 2021 17:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49723 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16271483786094 (code B ref -1); Sat, 24 Jul 2021 17:40:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Jul 2021 17:39:38 +0000 Original-Received: from localhost ([127.0.0.1]:46886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Lcg-0001aD-Dr for submit@debbugs.gnu.org; Sat, 24 Jul 2021 13:39:38 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:36456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Lcf-0001a6-BN for submit@debbugs.gnu.org; Sat, 24 Jul 2021 13:39:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Lcf-0000tv-3W for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2021 13:39:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46552) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Lce-0004wT-RG; Sat, 24 Jul 2021 13:39:36 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4846 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Lce-0006eT-Cd; Sat, 24 Jul 2021 13:39:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210652 Archived-At: From: eliz@HOME-C4E4A596F7.i-did-not-set--mail-host-address--so-tickle-me --text follows this line-- Emacs currently tries to catch null bytes in file names in encode_file_name, after encoding the file name. But that is not reliable enough, because it assumes that the call to expand-file-name at the beginning of encode_file_name leaves those null bytes intact. That is not guaranteed, and in fact doesn't happen at least on MS-Windows: the file name gets chopped after the first null byte, and doesn't trigger the test in encode_file_name. So for a more reliable test we need to include such a check inside expand-file-name (and then we could probably drop the test in encode_file_name, because Emacs always runs file names through expand-file-name before using them). In GNU Emacs 28.0.50 (build 1573, i686-pc-mingw32) of 2021-07-24 built on HOME-C4E4A596F7 Repository revision: 7c83e605ab84e8b62254c55f347abc8aa9c6057b Repository branch: master Windowing system distributor 'Microsoft Corp.', version 5.1.2600 System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) Configured using: 'configure -C --prefix=/d/usr --with-wide-int --with-modules --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' Configured features: ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XPM ZLIB Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 56888 7103) (symbols 48 7785 1) (strings 16 21560 2884) (string-bytes 1 630636) (vectors 16 13320) (vector-slots 8 173301 9720) (floats 8 23 47) (intervals 40 265 116) (buffers 888 10))