From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49788: 28.0.50; [PATCH] Package archive location needs to be absolute Date: Sat, 31 Jul 2021 09:27:19 +0300 Message-ID: <83o8ajov5k.fsf@gnu.org> References: <87a6m3b7wj.fsf@dick> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11923"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49788@debbugs.gnu.org To: dick.r.chiang@gmail.com, Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 31 08:33:37 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9iYy-00030G-TJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Jul 2021 08:33:36 +0200 Original-Received: from localhost ([::1]:39126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9iYx-0007Eu-Pl for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Jul 2021 02:33:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9iTa-0005mu-KW for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 02:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49819) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m9iTa-0001UC-BJ for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 02:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m9iTa-0008Fc-2j for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 02:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Jul 2021 06:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49788 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49788-submit@debbugs.gnu.org id=B49788.162771285931683 (code B ref 49788); Sat, 31 Jul 2021 06:28:02 +0000 Original-Received: (at 49788) by debbugs.gnu.org; 31 Jul 2021 06:27:39 +0000 Original-Received: from localhost ([127.0.0.1]:33132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9iTD-0008Ex-Bp for submit@debbugs.gnu.org; Sat, 31 Jul 2021 02:27:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9iTC-0008El-EK for 49788@debbugs.gnu.org; Sat, 31 Jul 2021 02:27:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42620) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9iT7-00016H-4T; Sat, 31 Jul 2021 02:27:33 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1069 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9iT6-00044I-Nd; Sat, 31 Jul 2021 02:27:33 -0400 In-Reply-To: <87a6m3b7wj.fsf@dick> (dick.r.chiang@gmail.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210960 Archived-At: > From: dick.r.chiang@gmail.com > Date: Fri, 30 Jul 2021 21:15:40 -0400 > > Now that bug#48137 can change default-directory in the middle > of `package-install-file`, the error regarding package archive > locations needing to be absolute is now important enough that > it actually needs to trigger. > > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index f1daa8d124..dfda201af6 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -1366,10 +1366,10 @@ package--with-response-buffer-1 > (kill-buffer buffer) > (goto-char (point-min)))))) > (package--unless-error body > + (unless (file-name-absolute-p url) > + (error "Location %s is not a url nor an absolute file name" > + url)) > (let ((url (expand-file-name file url))) > - (unless (file-name-absolute-p url) > - (error "Location %s is not a url nor an absolute file name" > - url)) > (insert-file-contents-literally url))))) > > (define-error 'bad-signature "Failed to verify signature") Hmm.. if we require it to be an absolute file name, why run it through expand-file-name? Stefan, any comments?