From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50424: 27.2; Tab bar button mouse face not clearing entirely Date: Mon, 13 Sep 2021 14:59:23 +0300 Message-ID: <83o88weles.fsf@gnu.org> References: <87eea2cebb.fsf.ref@yahoo.com> <87eea2cebb.fsf@yahoo.com> <83eea2rn8z.fsf@gnu.org> <87h7exc2dk.fsf@yahoo.com> <83lf49r4bc.fsf@gnu.org> <87czplb51o.fsf@yahoo.com> <83ilzcpt0d.fsf@gnu.org> <83mtonob41.fsf@gnu.org> <87tuiryn17.fsf@mail.linkov.net> <831r5uhpd3.fsf@gnu.org> <8735qazyjv.fsf@mail.linkov.net> <83zgsifob4.fsf@gnu.org> <87zgsii8cy.fsf@mail.linkov.net> <83k0jmfay2.fsf@gnu.org> <87lf41hlym.fsf@mail.linkov.net> <835yv5g3rp.fsf@gnu.org> <877dfkhpnz.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22746"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 50424@debbugs.gnu.org, alan@idiocy.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 13 14:09:38 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPkmI-0005jm-Fo for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 14:09:38 +0200 Original-Received: from localhost ([::1]:51280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPkmH-0003k7-BW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 08:09:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPkd0-0007G4-MM for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 08:00:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32978) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPkd0-0007LO-B0 for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 08:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPkd0-0005zR-8W for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 08:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Sep 2021 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50424 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 50424-submit@debbugs.gnu.org id=B50424.163153438322962 (code B ref 50424); Mon, 13 Sep 2021 12:00:02 +0000 Original-Received: (at 50424) by debbugs.gnu.org; 13 Sep 2021 11:59:43 +0000 Original-Received: from localhost ([127.0.0.1]:44522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPkcg-0005yI-Re for submit@debbugs.gnu.org; Mon, 13 Sep 2021 07:59:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPkcf-0005y5-HE for 50424@debbugs.gnu.org; Mon, 13 Sep 2021 07:59:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33924) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPkcY-00070U-7K; Mon, 13 Sep 2021 07:59:34 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4341 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPkcW-0002X1-Ue; Mon, 13 Sep 2021 07:59:33 -0400 In-Reply-To: <877dfkhpnz.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 13 Sep 2021 10:59:12 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214216 Archived-At: > From: Juri Linkov > Cc: alan@idiocy.org, luangruo@yahoo.com, 50424@debbugs.gnu.org > Date: Mon, 13 Sep 2021 10:59:12 +0300 > > >> -#define DEFAULT_TAB_BAR_BUTTON_MARGIN 4 > >> +#define DEFAULT_TAB_BAR_BUTTON_MARGIN 1 > >> #define DEFAULT_TAB_BAR_BUTTON_RELIEF 1 > > > > Btw, I don't see much sense in keeping the > > DEFAULT_TAB_BAR_BUTTON_MARGIN macro: it's used in one place only, > > AFAICT, so we could simply have it there literally. > > I thought about this too, but it will break the symmetry with > DEFAULT_TOOL_BAR_BUTTON_MARGIN and DEFAULT_TOOL_BAR_BUTTON_RELIEF when > DEFAULT_TAB_BAR_BUTTON_MARGIN will be used in more places. The *_RELIEF variables are used in more than one place, so it makes sense to have them. As for the "symmetry" with the tool bar: it doesn't really exist, since you do almost everything related to the tab-bar button display in Lisp, not in C. That "symmetry" is very misleading, so much so that the other day it cost me 2 hours of frustrating debugging before I realized why the image parameters I see in w32term.c are so different from what Vtab_bar_button_margin says it should be.