From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50571: 28.0.50; Redisplay segfaults with empty face cache Date: Wed, 15 Sep 2021 16:16:41 +0300 Message-ID: <83o88uashy.fsf@gnu.org> References: <87ilz4msha.fsf@tcd.ie> <831r5sea46.fsf@gnu.org> <87a6kggiz6.fsf@tcd.ie> <83bl4vcnsp.fsf@gnu.org> <83a6kfcmdk.fsf@gnu.org> <87y27zuek1.fsf@tcd.ie> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19248"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50571-done@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 15 15:21:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mQUqy-0004mF-No for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Sep 2021 15:21:32 +0200 Original-Received: from localhost ([::1]:34996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQUqx-0006F1-L5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Sep 2021 09:21:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQUmc-0000w0-VS for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2021 09:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQUmc-00035Q-N5 for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2021 09:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQUmc-0003vF-HC for bug-gnu-emacs@gnu.org; Wed, 15 Sep 2021 09:17:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Sep 2021 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 50571 X-GNU-PR-Package: emacs Mail-Followup-To: 50571@debbugs.gnu.org, eliz@gnu.org, contovob@tcd.ie Original-Received: via spool by 50571-done@debbugs.gnu.org id=D50571.163171182115063 (code D ref 50571); Wed, 15 Sep 2021 13:17:02 +0000 Original-Received: (at 50571-done) by debbugs.gnu.org; 15 Sep 2021 13:17:01 +0000 Original-Received: from localhost ([127.0.0.1]:51286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQUmb-0003ut-Ek for submit@debbugs.gnu.org; Wed, 15 Sep 2021 09:17:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQUmV-0003uc-WE for 50571-done@debbugs.gnu.org; Wed, 15 Sep 2021 09:16:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34540) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQUmP-0002zJ-QV; Wed, 15 Sep 2021 09:16:49 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4256 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQUmP-0002fs-57; Wed, 15 Sep 2021 09:16:49 -0400 In-Reply-To: <87y27zuek1.fsf@tcd.ie> (contovob@tcd.ie) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214396 Archived-At: > From: "Basil L. Contovounesios" > Cc: 50571@debbugs.gnu.org > Date: Tue, 14 Sep 2021 20:45:18 +0100 > > >> Thanks, I see the reason now. It's because we allow to have arbitrary > >> Lisp to be registered in jit-lock-functions, and then that arbitrary > >> Lisp is called in the middle of redisplay, and in this case creates a > >> whole new frame with faces. As luck would have it, we decide right > >> there and then perform routine maintenance and release all the faces > >> on all the frames... > >> > >> I'm thinking about the best solution for this. > > > > Does the patch below give good results? > > Yes, applying it makes the issue go away, and reverting it reintroduces > the segfault. I didn't notice any other issues. Thanks! Thanks, I've now installed these changes, and I'm therefore closing the bug.