From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50660: 28.0.50; Text artifacting when the cursor moves over text under mouse face that originally displayed a box Date: Mon, 20 Sep 2021 15:36:12 +0300 Message-ID: <83o88n1l1f.fsf@gnu.org> References: <87czp6ysw7.fsf.ref@yahoo.com> <87czp6ysw7.fsf@yahoo.com> <87y27uro4c.fsf@gnus.org> <877dfdz9ni.fsf@yahoo.com> <831r5l5d6d.fsf@gnu.org> <87h7egy8jo.fsf@yahoo.com> <838rzs4i09.fsf@gnu.org> <87fsu06oxi.fsf@yahoo.com> <83ee9j3ju3.fsf@gnu.org> <834kaf3ets.fsf@gnu.org> <8335pz3dli.fsf@gnu.org> <87r1dj4q4m.fsf@yahoo.com> <83zgs71su7.fsf@gnu.org> <87k0jb4k5l.fsf@yahoo.com> <83sfxz1pw0.fsf@gnu.org> <87ee9j4i8y.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23229"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 50660@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 20 14:38:02 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSIYc-0005vk-JB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 14:38:02 +0200 Original-Received: from localhost ([::1]:56572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSIYb-0004Ga-JS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 08:38:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSIXe-0003Vo-Ux for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 08:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57881) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSIXe-0008R1-MZ for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 08:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSIXe-0006gt-Jc for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 08:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Sep 2021 12:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50660 X-GNU-PR-Package: emacs Original-Received: via spool by 50660-submit@debbugs.gnu.org id=B50660.163214138925658 (code B ref 50660); Mon, 20 Sep 2021 12:37:02 +0000 Original-Received: (at 50660) by debbugs.gnu.org; 20 Sep 2021 12:36:29 +0000 Original-Received: from localhost ([127.0.0.1]:41190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSIX7-0006fm-74 for submit@debbugs.gnu.org; Mon, 20 Sep 2021 08:36:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSIX5-0006fZ-PY for 50660@debbugs.gnu.org; Mon, 20 Sep 2021 08:36:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58262) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSIX0-00089j-I6; Mon, 20 Sep 2021 08:36:22 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2340 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSIWz-0006fR-IS; Mon, 20 Sep 2021 08:36:22 -0400 In-Reply-To: <87ee9j4i8y.fsf@yahoo.com> (message from Po Lu on Mon, 20 Sep 2021 19:08:13 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214859 Archived-At: > From: Po Lu > Cc: larsi@gnus.org, 50660@debbugs.gnu.org > Date: Mon, 20 Sep 2021 19:08:13 +0800 > > Thanks, but I already cooked something up. The adjustment, in my case, > is done in draw_phys_cursor_glyph, conditional on > cursor_in_mouse_face_p. > > Is there anything wrong with this approach? Thanks. One other problem with this implementation is that the additional code will run when the mouse-highlight is removed as well, in which case we know that no adjustment is needed for w->phys_cursor.x. Also, I think it's incorrect to add mouse->box_vertical_line_width to _every_ glyph that in the regular face has this attribute. That's because the entire mouse-highlighted area has just two glyphs which could have a box line near it: the first and the last one. So you should only add it once. Try this code on a screen line with several different stretches of characters with the box face, and arrange for all of these stretches to be mouse-highlighted together. Moreover, if the mouse-highlighted text takes more than one screen line (a.k.a. "glyph row"), only the first screen line/glyph row need to have the mouse->box_vertical_line_width added.