From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Date: Thu, 02 Dec 2021 11:45:45 +0200 Message-ID: <83o85zpcfq.fsf@gnu.org> References: <868u41rv84.fsf@yandex.ru> <83fuy8p8oq.fsf@gnu.org> <568FA9D0.2040609@yandex.ru> <83egdsp88n.fsf@gnu.org> <568FABFC.3000205@yandex.ru> <87tufr74of.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26076"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 22324@debbugs.gnu.org, dgutov@yandex.ru To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 02 10:47:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msigJ-0006Wv-4l for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Dec 2021 10:47:11 +0100 Original-Received: from localhost ([::1]:33836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msigI-0005yq-1G for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Dec 2021 04:47:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msigA-0005wr-OI for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 04:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35085) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1msigA-0000hm-Fb for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 04:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1msigA-0005Gz-Bw for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 04:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2021 09:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22324 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 22324-submit@debbugs.gnu.org id=B22324.163843837317883 (code B ref 22324); Thu, 02 Dec 2021 09:47:02 +0000 Original-Received: (at 22324) by debbugs.gnu.org; 2 Dec 2021 09:46:13 +0000 Original-Received: from localhost ([127.0.0.1]:46631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msifM-0004e0-OE for submit@debbugs.gnu.org; Thu, 02 Dec 2021 04:46:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msifJ-0004Wx-5k for 22324@debbugs.gnu.org; Thu, 02 Dec 2021 04:46:11 -0500 Original-Received: from [2001:470:142:3::e] (port=36582 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msifD-0006DK-KC; Thu, 02 Dec 2021 04:46:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ksqny7TRe0XHVdKSG89T/uTSI5Bs7VXpToJuwtPvgKs=; b=rSEzoyNPINHO DMuk4xyKEe+Dq/svEDoAqARbRMPvb7BtxNsMLCkRl+6FA6aU9Vojg1dpTpeJa3a1SExMtFN4zad4c NV/1x+NiBDiJ7VgvYr2gWp44PWH3LOy0/Jfi2EIqP9aZ1t6Stc8fWotjNPyw6cuOF4Km0yiEwmNsf RSKPxtmtPiA1K1gjJtFh7oXHZiVBZuuU9B0/eTxRdGDU5+MEMBbQf/OB/tGzP8QujfMlHdfItlTX4 IRePCNXQeZQmrRAGvU0j9YwEAz8OImyimYdyK+37TjbbkE//mz9RAigZPXf+hguaq37oV0iLtG8V6 qrrZ3lRvuuXRaBzemW4Hww==; Original-Received: from [87.69.77.57] (port=3140 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msif9-0006tI-1u; Thu, 02 Dec 2021 04:46:00 -0500 In-Reply-To: <87tufr74of.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 02 Dec 2021 10:10:40 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221273 Archived-At: > From: Lars Ingebrigtsen > Cc: Eli Zaretskii , 22324@debbugs.gnu.org > Date: Thu, 02 Dec 2021 10:10:40 +0100 > > Dmitry Gutov writes: > > > On 01/08/2016 03:26 PM, Eli Zaretskii wrote: > > > >> Thanks, that wasn't clear from the problem description. Normally, > >> when someone says "the documentation doesn't describe the behavior > >> accurately", they mean the documentation should be updated. > > > > Right, sorry. Poor wording on my part. > > > > But if you were talking about a documentation fix, changing the list > > in `(emacs) Completion Styles' to include `partial-completion' is not > > a good fix semantically, because the result would still contain the > > word "only". > > This bug report is a bit on the vague side. > > It looks like `partial-completion' is documented in that node? > > The subject mentions "doesn't override", but is that about > `completion-category-overrides' instead? > > --- > This overrides the defaults specified in `completion-category-defaults'." > --- > > And it does indeed prepend: > > (defun completion--category-override (category tag) > (or (assq tag (cdr (assq category completion-category-overrides))) > (assq tag (cdr (assq category completion-category-defaults))))) > > But... I think saying that that "overrides" is fine? > > So it's unclear what's suggested in this bug report. I think the problem is that we don't clearly document how the list of styles to be actually used for some CATEGORY is obtained from the various contributions, like completion-category-defaults and completion-category-overrides, and what is the priority of each contribution in the resulting list of styles.