From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Date: Sun, 12 Dec 2021 09:02:04 +0200 Message-ID: <83o85mpaqb.fsf@gnu.org> References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17747"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52293@debbugs.gnu.org, juri@linkov.net To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 12 08:03:37 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwItU-0004Ph-Rw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 08:03:37 +0100 Original-Received: from localhost ([::1]:48482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwItT-0004OB-Lu for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 02:03:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwIsw-0004Ls-VP for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 02:03:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwIsw-0003Y8-Ll for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 02:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwIsw-0002UB-Cm for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 02:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 07:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.16392925408790 (code B ref 52293); Sun, 12 Dec 2021 07:03:02 +0000 Original-Received: (at 52293) by debbugs.gnu.org; 12 Dec 2021 07:02:20 +0000 Original-Received: from localhost ([127.0.0.1]:50547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwIsF-0002HR-M4 for submit@debbugs.gnu.org; Sun, 12 Dec 2021 02:02:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwIsE-0002Bo-4u for 52293@debbugs.gnu.org; Sun, 12 Dec 2021 02:02:18 -0500 Original-Received: from [2001:470:142:3::e] (port=52768 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwIs8-0003TH-P0; Sun, 12 Dec 2021 02:02:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZHOTU9YjHu2C1VHxr/9jbi9otwpG6LmVlGRVMt2Z5+4=; b=oFZFoCNP4Jef M/9H1r0ompaYPZvRxZkuxz9Rggp9IKD2+dKdHrhIeTQdjrw/hMs3zibKf7Cjy2+LDUzMMqjrEKkhW PPqN3wD+CGH9AzoXhFrOBsWD+K3sg7tpoqL9sZVUVy9sMQ3JyxNVuLwJb0RxZkkEhGmrj4b0pmy/f 0zx7xY+ChI3ZixqPIoVRCJ+fOQbjIVlQhqkcbnLzCvwg7AtqnL1+jCyotntogkXWWSoD0gi0kWVy0 94hiEcZsV9F6NTnxV+1k/3wtn+XBdZPYnx5g7o4+nfR5iNwMDkpN/AcCZ2ee9iqMCsPyA/GTf6YeT 1Mk6Gx1J8chbBtA8wYj2wg==; Original-Received: from [87.69.77.57] (port=3527 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwIs8-0002Yz-JP; Sun, 12 Dec 2021 02:02:12 -0500 In-Reply-To: <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> (message from Jim Porter on Sat, 11 Dec 2021 20:02:41 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222179 Archived-At: > Cc: 52293@debbugs.gnu.org > From: Jim Porter > Date: Sat, 11 Dec 2021 20:02:41 -0800 > > > Yes. This way, we have quite some time before us to let people bump > > into any problems this could cause and report back to us. > > That's ok by me. Note that this[1] is a very mildly incompatible change, > so as long as people are aware of that, I think it should be ok to merge > into 29, and hopefully into 28.2. The only incompatibility would be > people wanting to add context menu items after certain specific > separators like `global-separator' or `undo-separator'. I think that's > fairly unlikely though, since: > > a) `context-menu-mode' is new so there aren't many (any?) third-party > packages that use it yet. > > b) `context-menu-mode' doesn't guarantee that any particular items are > actually present in the menu. Users can customize the context menu, so > it could have anything at all in it. Relying on the presence of > `global-separator' (however it's named) would be somewhat risky. > `middle-separator' and `top-separator' (the latter is from the patch in > this bug) are/will be at least *likely* to be present though, so are > more likely to be used in third-party code. Are you saying that we will be recommending a convention for separator names only for menus popped up in context-menu-mode? Does it make sense to have such a specialized convention? Isn't it possible to show context menus outside of the context-menu-mode?