From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken Date: Tue, 22 Feb 2022 15:09:13 +0200 Message-ID: <83o82zt5dy.fsf@gnu.org> References: <7da3e8b2-7400-dca6-6d92-0a60e3d9c215@gmail.com> <83mtinz222.fsf@gnu.org> <83ley6y5gx.fsf@gnu.org> <83a6emxak3.fsf@gnu.org> <272c6d13-6d35-a896-1468-2c9bc3befe87@gmail.com> <83a6ekuomt.fsf@gnu.org> <87k0dof7az.fsf@gnus.org> <835yp8ul58.fsf@gnu.org> <71c773bd-1166-8d36-5dac-8d6b81240a2a@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40242"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 54062@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 22 14:18:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMV3U-000AHj-7K for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Feb 2022 14:18:12 +0100 Original-Received: from localhost ([::1]:54280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMV3R-0007G2-Eh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Feb 2022 08:18:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMUva-0002bs-9h for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2022 08:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46381) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMUvZ-0003eV-Vu for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2022 08:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMUvZ-0004OT-Ko for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2022 08:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Feb 2022 13:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54062-submit@debbugs.gnu.org id=B54062.164553535316825 (code B ref 54062); Tue, 22 Feb 2022 13:10:01 +0000 Original-Received: (at 54062) by debbugs.gnu.org; 22 Feb 2022 13:09:13 +0000 Original-Received: from localhost ([127.0.0.1]:40278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMUun-0004NJ-F5 for submit@debbugs.gnu.org; Tue, 22 Feb 2022 08:09:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMUul-0004N6-JM for 54062@debbugs.gnu.org; Tue, 22 Feb 2022 08:09:12 -0500 Original-Received: from [2001:470:142:3::e] (port=46760 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMUug-0003TW-94; Tue, 22 Feb 2022 08:09:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kV6lSlpzasQgKYHdiOkiNr4qqdyywcv+oLW6oeoauhk=; b=kaMB/0snGL53 daUwF17zgoaNRJWFteKE4OslAuIuaQ46owf5mit9hzKS7IzOFgws7Txr6ARu6N3YzlqiNsslVSAlj XMz6Cb18yiSZRFBl17EMFAX3yC2m94wtaEq1d9o/olF5oenz+VIXwK3aD+z4z7pbD4lFxNequSUPq /rOYmn2EHKJ9Xhg6S0OHckgDngNUfchBKyjdrMGuguwunkPZqBu4/6rj/4WkhmJiIv9vWyY3kpFTu TiemuzD3K3+AAGmwJU9DpkStx5KDieyw2orRtZw1hR0rJgbJh36tAJnGG5GsGj/jxi/eqLPuUCG8j 8m8F9L57694386Ea8sVepQ==; Original-Received: from [87.69.77.57] (port=3535 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMUuf-0008GN-Pe; Tue, 22 Feb 2022 08:09:06 -0500 In-Reply-To: <71c773bd-1166-8d36-5dac-8d6b81240a2a@gmail.com> (message from Jim Porter on Mon, 21 Feb 2022 12:37:59 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227421 Archived-At: > Cc: 54062@debbugs.gnu.org > From: Jim Porter > Date: Mon, 21 Feb 2022 12:37:59 -0800 > > Attached is a patch that ignores the `eshell-pipe-broken' error in > `eshell-sentinel'. It's not really an error in that case anyway, since > we only want to write the last bit of output *if we can*. Thanks, this fixes the test. However, I'm unsure we should fix this inside eshell-sentinel: do we always want to ignore "broken pipe" errors in Eshell subprocesses, and never show them to the user?