From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54399: 27.2; Problems with (let ((custom-variable ...)) (autoload-function ...)) Date: Thu, 12 May 2022 11:36:40 +0300 Message-ID: <83o803p2p3.fsf@gnu.org> References: <83sfqi498s.fsf@gnu.org> <87ilrdg837.fsf@web.de> <87ilqb1nwf.fsf@gnus.org> <83r14zp5jz.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10385"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, larsi@gnus.org, 54399@debbugs.gnu.org, monnier@iro.umontreal.ca To: Ignacio Casso Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 12 11:22:05 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1np51J-0002QB-4K for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 May 2022 11:22:05 +0200 Original-Received: from localhost ([::1]:48422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1np51H-00062I-Rw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 May 2022 05:22:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np4Kg-0004ld-PZ for bug-gnu-emacs@gnu.org; Thu, 12 May 2022 04:38:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1np4Kg-0007DY-8K for bug-gnu-emacs@gnu.org; Thu, 12 May 2022 04:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1np4Kg-0006Tz-6M for bug-gnu-emacs@gnu.org; Thu, 12 May 2022 04:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 May 2022 08:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54399 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 54399-submit@debbugs.gnu.org id=B54399.165234462624800 (code B ref 54399); Thu, 12 May 2022 08:38:02 +0000 Original-Received: (at 54399) by debbugs.gnu.org; 12 May 2022 08:37:06 +0000 Original-Received: from localhost ([127.0.0.1]:39592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1np4Ja-0006Qv-0y for submit@debbugs.gnu.org; Thu, 12 May 2022 04:37:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1np4JY-0006Qa-I0 for 54399@debbugs.gnu.org; Thu, 12 May 2022 04:36:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np4JL-00072i-Cm; Thu, 12 May 2022 04:36:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OiXQYK2xMsL/S83IbUWg8YIF6c8l785iH7LnI+ap0kI=; b=OaVkiGXvl5bY na4cxcU4hpR0M5rBRACOWP5F8eT4EkV1S0eCeIzaoVpYQTvOaTaL0FCYu4NxO1QJB9m7JFwa2e0Aw CtcBCBmjCZYzx8qYNY1erJfcaRsT16VtFr4wsXp+H0nRYMut0pXEvjN4iRWsER+codKmSq4jqqJas akpbHmtsv4XKtYFIP0Ek63CgkOPCyICv7rstgPQjLZIIV/8QfQFNjPfLjbGiPx5+VBNhVVoRzO+FV eyKK+N8RBafDPS/hs0nlT2U+AAqrFdKAMEtyx0vTkfPAtcpbfu/LqN4ON+jOcO0Xh9Mm0C7WIg1QI DffYdFm0FZrIP1L/8wcY9g==; Original-Received: from [87.69.77.57] (port=4430 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np4JK-0004kn-6R; Thu, 12 May 2022 04:36:38 -0400 In-Reply-To: (message from Ignacio Casso on Thu, 12 May 2022 10:14:13 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232029 Archived-At: > From: Ignacio Casso > Cc: larsi@gnus.org, michael_heerdegen@web.de, 54399@debbugs.gnu.org, > monnier@iro.umontreal.ca > Date: Thu, 12 May 2022 10:14:13 +0200 > > > This doesn't just change documentation, it also changes some code. > > Do you say it because of the commit message? No, because of this: > - (let* ((get (or (get symbol 'custom-get) #'default-value)) > + (let* ((get (or (get symbol 'custom-get) #'default-toplevel-value)) and this: > @@ -114,7 +114,7 @@ custom-initialize-changed > symbol > (eval (car (get symbol 'saved-value))))) > (t > - (set-default symbol (eval exp))))))) > + (set-default-toplevel-value symbol (eval exp))))))) and several similar changes. > I was waiting until you agreed on the patch to write a proper one > following the guidelines. > > Or if you want a patch with only documentation changes, I can > update it, but the changes are just using the toplevel versions in a > few places that were missing. My point is that you seemed to be sating that you suggest a documentation change, but the changeset actually changes some code. So I'm not sure anymore what is this changeset about. Perhaps I forgot what we were discussing at the beginning, since that was quite some time ago. Can you remind?