From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Fri, 11 Nov 2022 10:30:25 +0200 Message-ID: <83o7tdq4f2.fsf@gnu.org> References: <8cf8ba5d-c604-b2dc-274a-7597b19fb73f@dfreeman.email> <87ilk5xq01.fsf@gmail.com> <87r0yrwfn3.fsf@gmail.com> <37716e41-5955-99f6-5204-e760a716fbf6@yandex.ru> <9bb290c8-f000-31d8-265d-b5441c33eb38@dfreeman.email> <4d50b820-7053-75eb-5b11-d3d36a02b013@dfreeman.email> <87v8nxsrq6.fsf@gmail.com> <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11128"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58790@debbugs.gnu.org, felician.nemeth@gmail.com, stefankangas@gmail.com, danny@dfreeman.email, dgutov@yandex.ru To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 11 09:32:34 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otPSj-0002jY-0A for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Nov 2022 09:32:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otPRH-00045O-V5; Fri, 11 Nov 2022 03:31:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otPRG-0003yq-QD for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 03:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otPRG-00032L-Gq for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 03:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otPRG-0008I8-Cw for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 03:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Nov 2022 08:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166815543331835 (code B ref 58790); Fri, 11 Nov 2022 08:31:02 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 11 Nov 2022 08:30:33 +0000 Original-Received: from localhost ([127.0.0.1]:45047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otPQm-0008HP-Ud for submit@debbugs.gnu.org; Fri, 11 Nov 2022 03:30:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otPQk-0008HC-2J for 58790@debbugs.gnu.org; Fri, 11 Nov 2022 03:30:31 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otPQe-0002m7-K1; Fri, 11 Nov 2022 03:30:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Dwh/a8p7mMTZTXzF/ZcLYE4vVhydzcRU9Yb/O1aKJKY=; b=U7ic7Vkfzpf2ftrBFy5T tcJGMhlJ5DJ4HzhBlRNEKnpkORFrJCvviKZPGL7NObwQfI/yohmvr8xr8NFYab7Ye3iogL4P/aT/b aynQLGnfuqILxtIBPDx8/gOC5GuwtnPciCwlVsE2Llno0oiD/D84DhAO9KUhO8WO11HLL3DjPidw+ N0s8NH0Og8CvMfcQVog3bSvtQ7qc1OkV/yZvvVlOzyWUnMUciJU6W1zPfvf+aJgmb5N8CESVyz6cC Tpos6aYxw4yFjAY7NnDKtkHdlNBNX3bACDRMCrfidRLyz9IO6hSeCAMVjjinuKcAqKeA3nNrB4Bhb rY22XO17XkDttg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otPQe-0000MJ-3N; Fri, 11 Nov 2022 03:30:24 -0500 In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Thu, 10 Nov 2022 21:59:37 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247577 Archived-At: > From: João Távora > Date: Thu, 10 Nov 2022 21:59:37 +0000 > Cc: Eli Zaretskii , 58790@debbugs.gnu.org, felician.nemeth@gmail.com, > stefankangas@gmail.com, dgutov@yandex.ru > > But when dealing with eglot.el, which I am the prime maintainer of, > I really prefer to see design described in the commit message where the > design was introduced. It plays very well with vc-region-history. This is not the design, these are comments that explain why the code does what it does the way it does that. IOW, these are implementation notes aimed at making the code more self-explanatory and easier to maintain. It is quite possible that you personally don't need these additional comments because you are very familiar with the code and with LSP servers in general. But future Emacs developers and maintainers might not have such insight, and I'm trying to represent them. This is part of my job and my responsibility. And since comments can never adversely affect code, I see no reason for you to object. vc-region-history is a very useful command, but in my book the code should explain itself; vc-region-history is for when one wants to understand the reasons for a change, not when one wants to study the code as a whole. I'm not objected to having the explanations in the commit log messages, but why would you object to having them in the code, even if the commit log already says that? That way everyone wins.