unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "M. Ian Graham" <hello+emacs@miangraham.com>
Cc: 59214@debbugs.gnu.org, pankaj@codeisgreat.org, joaotavora@gmail.com
Subject: bug#59214: [PATCH] Alternate rust-analyzer command added
Date: Thu, 17 Nov 2022 20:47:52 +0200	[thread overview]
Message-ID: <83o7t5ct9j.fsf@gnu.org> (raw)
In-Reply-To: <JruIvGkI9N3mrX_MiMe2hreQe1Sk5Q7B2Q2XJ_1rfvpYNPwTO4wSux2z_7Lk05kNWOyJtCwsQL89EmsMoXGeqG723dJJu5OF7_nCPUSPW7M=@miangraham.com> (hello+emacs@miangraham.com)

> Date: Thu, 17 Nov 2022 18:11:32 +0000
> From: "M. Ian Graham" <hello+emacs@miangraham.com>
> Cc: 59214@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>, João Távora <joaotavora@gmail.com>
> 
> Pankaj Jangid <pankaj@codeisgreat.org> wrote:
> 
> > -(defvar eglot-server-programs `((rust-mode . ,(eglot-alternatives '("rust-analyzer" "rls")))
> > +(defvar eglot-server-programs `((rust-mode . ,(eglot-alternatives '("rust-analyzer" "("rustup" "run" "stable" "rust-analyzer") "rls")))
> 
> I just noticed this quote from the announcement at https://blog.rust-lang.org/2022/09/22/Rust-1.64.0.html#rust-analyzer-is-now-available-via-rustup :
> 
> > At this time, to run the rustup-installed version, you need to invoke it this way:
> > rustup run stable rust-analyzer
> > The next release of rustup will provide a built-in proxy so that running the executable rust-analyzer will launch the appropriate version.
> 
> So the current situation is temporary. A rustup-side fix is coming. Once it arrives, the right answer--even for rustup users--will be "just add what you want to PATH and eglot will defer to your environment." Rustup will do this for them automatically, for the rust version of their preference, and eglot will just work.
> 
> In the meantime, as is, rustup users have the option of symlinking rust-analyzer into .cargo/bin or adding its location directly to PATH. Anyone not comfortable doing this is also probably not running emacs from master, so they're unlikely to benefit from a short-term elisp fix until the problem goes away. And if emacs adds code depending on rustup, subsequently removing what should theoretically be a temporary fix will in practice break users remaining on older rustup versions.
> 
> Unless I'm misunderstanding the situation above or something has changed since the announcement, to me it seems prudent to wait on rustup's fix and avoid letting emacs develop an opinion about the installation method or version details of external components.

FWIW, I think Rust is too crazy for us to follow its daily changes and
offer support for its server OOTB in eglot-server-programs.  Emacs is
not equipped to follow such frequent and radical changes.  If we want
to make this seamless for users of Rust, we should provide a special
command to update eglot-server-programs with whatever it is the latest
Rust fashion.  Or maybe we should even leave that to Rust mode.





  parent reply	other threads:[~2022-11-17 18:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-12 11:53 bug#59214: [PATCH] Alternate rust-analyzer command added Pankaj Jangid
2022-11-12 12:03 ` Eli Zaretskii
2022-11-12 12:22   ` Pankaj Jangid
2022-11-12 12:51     ` Eli Zaretskii
2022-11-12 13:09       ` Pankaj Jangid
2022-11-16 17:05 ` Eli Zaretskii
2022-11-16 17:14   ` João Távora
2022-11-16 19:31     ` Eli Zaretskii
2022-11-16 21:06       ` João Távora
2022-11-17  0:12         ` Stefan Kangas
2022-11-17  5:59           ` Pankaj Jangid
2022-11-17  5:57         ` Pankaj Jangid
2022-11-17  8:13           ` João Távora
2022-11-17 10:18             ` Pankaj Jangid
2022-11-17 10:52           ` M. Ian Graham
2022-11-17 12:51             ` Pankaj Jangid
2022-11-17 18:11               ` M. Ian Graham
2022-11-17 18:20                 ` Pankaj Jangid
2022-11-17 18:47                 ` Eli Zaretskii [this message]
2022-11-17 19:43                   ` M. Ian Graham
2022-11-17 21:49                   ` João Távora
2022-11-18  5:13                     ` Pankaj Jangid
2022-11-18  8:29                       ` Eli Zaretskii
2022-11-18  8:44                         ` João Távora
2022-11-17  8:11         ` M. Ian Graham
2022-11-17  8:19           ` João Távora
2022-11-17  9:01             ` M. Ian Graham
2022-11-17  9:07               ` João Távora
2022-11-17 10:32             ` Pankaj Jangid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o7t5ct9j.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59214@debbugs.gnu.org \
    --cc=hello+emacs@miangraham.com \
    --cc=joaotavora@gmail.com \
    --cc=pankaj@codeisgreat.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).