From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59307: [PATCH] Cancel proced auto update timer if no proced buffers are open Date: Sun, 20 Nov 2022 12:35:45 +0200 Message-ID: <83o7t16hha.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="357"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59307@debbugs.gnu.org To: Laurence Warne Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 20 11:36:54 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owhgz-000ARa-D6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Nov 2022 11:36:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owhge-0001Lz-GI; Sun, 20 Nov 2022 05:36:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owhgF-0001FD-Tg for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 05:36:22 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owhgB-0001Eo-5n for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 05:36:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owhgA-00065z-E9 for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 05:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Nov 2022 10:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59307 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59307-submit@debbugs.gnu.org id=B59307.166894056023420 (code B ref 59307); Sun, 20 Nov 2022 10:36:02 +0000 Original-Received: (at 59307) by debbugs.gnu.org; 20 Nov 2022 10:36:00 +0000 Original-Received: from localhost ([127.0.0.1]:42405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owhg8-00065e-7C for submit@debbugs.gnu.org; Sun, 20 Nov 2022 05:36:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owhg3-00065N-U5 for 59307@debbugs.gnu.org; Sun, 20 Nov 2022 05:35:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owhfu-0001Dx-Mm; Sun, 20 Nov 2022 05:35:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kQHj2itVttYKBQxjJRFtG01ki03NC046RQ3TSlR4nNA=; b=dC7ydJiAO4vR RW2FgfV4W0I669ABGe9AWiZ5uSu9Offcf2XOKYgsq4zEb21KmXXVaTzDM4DTelFIcc9C6s+dKEgy/ DWEKBZU0Xwqrg2v6E6T3awtXd5cQ6ejhmmPwx6UPA5SRQ2m89SEvZRrBOsfx6sYmyGphaN36mhXg+ nBqdLnbINg+hWhAMWGWv81fdh8aOebaAFP6XnqbrN5Vz3KxGkezFg/4aJwqGEAqki4Kpni2g8S/SB 4IxU9KhgPUrYsSfmzAvH00nKp5STAQr+vWZ937cNlOSRV7kZ9xv7KumV9oSdIJk3AYMD1eCmjPzud UxDohcrB/hDJspZPPSbQXw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owhfk-0005tT-B0; Sun, 20 Nov 2022 05:35:44 -0500 In-Reply-To: (message from Laurence Warne on Wed, 16 Nov 2022 11:57:09 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248410 Archived-At: > From: Laurence Warne > Date: Wed, 16 Nov 2022 11:57:09 +0000 > > Hi, this patch cancels the proced auto update timer if it's detected that no proced buffers are open. Thanks, but the patch seems to be incomplete: it indeed cancels the timer when no buffer uses it, but it doesn't update the display when some buffer _does_ use the timer. So the effect of this patch is that invoking proced-toggle-auto-update to turn on the auto-update has no effect: the buffer is not updated as expected. To reproduce, apply the patch and then type M-x proced-toggle-auto-update RET The result is that the Proced display is not updated every 5 sec as expected, and the value of proced-auto-update-timer is nil. Did you post the right patch, and if so, how was it tested?