From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60210: 30.0.50; tab-bar height not recalculated when face changes Date: Sun, 01 Jan 2023 20:22:56 +0200 Message-ID: <83o7ri2jy7.fsf@gnu.org> References: <86sfh350ok.fsf@mail.linkov.net> <8335934yse.fsf@gnu.org> <83edsm2w2a.fsf@gnu.org> <86y1qurs4i.fsf@mail.linkov.net> <226b32f79feedbfa05f1@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23212"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60210@debbugs.gnu.org, juri@linkov.net To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 01 19:23:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pC2zG-0005oD-Pz for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Jan 2023 19:23:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC2zA-0007eJ-IL; Sun, 01 Jan 2023 13:23:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC2z9-0007dq-4K for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 13:23:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC2z8-0006SG-KM for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 13:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC2z8-0005VX-Fw for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 13:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jan 2023 18:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60210 X-GNU-PR-Package: emacs Original-Received: via spool by 60210-submit@debbugs.gnu.org id=B60210.167259738021149 (code B ref 60210); Sun, 01 Jan 2023 18:23:02 +0000 Original-Received: (at 60210) by debbugs.gnu.org; 1 Jan 2023 18:23:00 +0000 Original-Received: from localhost ([127.0.0.1]:41725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC2z5-0005V3-Kc for submit@debbugs.gnu.org; Sun, 01 Jan 2023 13:22:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC2z4-0005Ur-28 for 60210@debbugs.gnu.org; Sun, 01 Jan 2023 13:22:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC2yy-0006RL-AE; Sun, 01 Jan 2023 13:22:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rVsJlEEseTOw8bS2nnVG4rJHDgGbnx5ugHS2mx9yxes=; b=gySxUMxseyfg XcHnpgGy7DbI3oFEFIp/QX3iVITlZbFe1zwDH++fmrGx5IQNrFO9DIWxSOD/OfB1j7i2+aNu6odkK 78EQ2dxmnLMAxMliTlONM2YkCuL99lDEuFngbSEZdmVFfGmRkkun+qRt5wPKF4rY9aaYGekb9NUaZ CsDLvG53SAtVFaO3mC/Ydph5M/dd+INnm/Nf5SRXGiJMOfXayflDBm7dAH0lvRjRWLzaFwQg8czAn OWybKE/ymclzN68GV0WJykCtQGVNN03gDS8fVQybXALWzmuqhDqy7TBp/EbTSVHe7G9qxtQpM8//i caPdyo8fo22tXdYBo59wdQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC2yx-0003c7-LX; Sun, 01 Jan 2023 13:22:51 -0500 In-Reply-To: <226b32f79feedbfa05f1@heytings.org> (message from Gregory Heytings on Sun, 01 Jan 2023 17:56:36 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252271 Archived-At: > Date: Sun, 01 Jan 2023 17:56:36 +0000 > From: Gregory Heytings > cc: 60210@debbugs.gnu.org > > The bug is that, in redisplay_tab_bar, WINDOW_PIXEL_HEIGHT (w) uses the > height of the default face, which is 39 pixels, whereas new_height, which > is computed with tab_bar_height, uses the font of the tab-bar face > (variable-pitch in emacs -Q). On my system, new_height is (with a single > *scratch* tab) 36 pixels. Therefore new_height < WINDOW_PIXEL_HEIGHT (w), > when in fact according to the logic of the code we should have new_height > == WINDOW_PIXEL_HEIGHT (w). I'm not sure I understand how the above causes the tab bar not to be displayed, or become empty. AFAIU, it just means the frame's change_tab_bar_height_hook will be called. What did I miss?