From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62009: 29.0.60; Emacs crashes on setf symbol-name Date: Fri, 10 Mar 2023 14:12:25 +0200 Message-ID: <83o7p0ztxy.fsf@gnu.org> References: <87o7p5of4n.fsf@daniel-mendler.de> <871qm01s6n.fsf@web.de> <9fcf05e8-506c-6566-e214-2ecf3194b85e@daniel-mendler.de> <83bkl45ul4.fsf@gnu.org> <87v8j9zl3i.fsf@posteo.net> <83a60l13p2.fsf@gnu.org> <16ecbe9ea8ba9d39d058@heytings.org> <16ecbe9ea85b22d008fd@heytings.org> <43460d2c-ba80-0f2f-656c-ef0aca5667b5@daniel-mendler.de> <87fsacx2qf.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21276"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, michael_heerdegen@web.de, mail@daniel-mendler.de, gregory@heytings.org, monnier@iro.umontreal.ca, 62009@debbugs.gnu.org, arstoffel@gmail.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 10 13:13:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pabcZ-0005IM-72 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Mar 2023 13:13:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pabcO-0003cX-LA; Fri, 10 Mar 2023 07:13:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pabcM-0003c3-PO for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 07:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pabcM-0004ZS-G4 for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 07:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pabcM-0005dS-Aq for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 07:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Mar 2023 12:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62009 X-GNU-PR-Package: emacs Original-Received: via spool by 62009-submit@debbugs.gnu.org id=B62009.167845037221644 (code B ref 62009); Fri, 10 Mar 2023 12:13:02 +0000 Original-Received: (at 62009) by debbugs.gnu.org; 10 Mar 2023 12:12:52 +0000 Original-Received: from localhost ([127.0.0.1]:53952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pabcC-0005d2-2N for submit@debbugs.gnu.org; Fri, 10 Mar 2023 07:12:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pabcA-0005cp-9p for 62009@debbugs.gnu.org; Fri, 10 Mar 2023 07:12:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pabc4-0004Ua-1h; Fri, 10 Mar 2023 07:12:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QNBzr8UrA8UnEQ9S0NUSEexUZaZGH1x9eP/tvtzkgJ0=; b=lnsM9ZUkCv6C hVg4UXE6QbWUTtdiGu/wm1bHiKOJ+Ci7NmV6LI7Msion8wCemu0PFp7RQ3o0HwLpuGaGgyGcOv7Ty bf1RHq5SxPJivXAif6G1Is7AUG4oHcTNI0rRUHwQKOFRK6moL7WGq5zXw+0NiOiqW8SLSkOJ4AeNZ cfx86ZmkMv890x92dCEBED7IxOo44IwNZuU7YuRz5fWUYO09xqjNnOvdxZoFTjM2td6MRaG+8POIf Gxf3XrOSFmXS9Fmdpsmw9GRKVuAUP7ivv13t3gNdEvfw+5Q5lES/Qo/hTa/b9Mj/3V3xLeXNx3PZn F6679w1h9hJvqzH+Hit2wQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pabc3-0000O7-8u; Fri, 10 Mar 2023 07:12:43 -0500 In-Reply-To: <87fsacx2qf.fsf@gmail.com> (message from Robert Pluim on Fri, 10 Mar 2023 12:30:48 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257686 Archived-At: > From: Robert Pluim > Cc: Gregory Heytings , Philip Kaludercic > , michael_heerdegen@web.de, > monnier@iro.umontreal.ca, 62009@debbugs.gnu.org, Eli Zaretskii > , Augusto Stoffel > Date: Fri, 10 Mar 2023 12:30:48 +0100 > > diff --git a/src/lisp.h b/src/lisp.h > index 1276285e2f2..80bbb047824 100644 > --- a/src/lisp.h > +++ b/src/lisp.h > @@ -1685,6 +1685,8 @@ SREF (Lisp_Object string, ptrdiff_t index) > INLINE void > SSET (Lisp_Object string, ptrdiff_t index, unsigned char new) > { > + if (XSTRING (string)->u.s.size_byte == -2) > + Fsignal (Qsetting_constant, string); "Setting constant" is misleading. And again, why do that at all? It's a waste of cycles, incurred on _everyone_, for an extremely rare use case that is explicitly discouraged. We are not the TSA, and should not adopt their policy of punishing the innocent 99.99% on behalf of a handful of villains.