* bug#63318: Variable ediff-auto-refine doesn't always default to "on"
@ 2023-05-05 20:21 Peter Oliver
2023-05-06 6:17 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Peter Oliver @ 2023-05-05 20:21 UTC (permalink / raw)
To: 63318
[-- Attachment #1: Type: text/plain, Size: 119 bytes --]
Severity: minor
Tags: patch
Document that variable ediff-auto-refine doesn't always default to "on".
--
Peter Oliver
[-- Attachment #2: Type: text/plain, Size: 1126 bytes --]
From 28b1350527adc9a9ba3575378cbac31711ffa056 Mon Sep 17 00:00:00 2001
From: Peter Oliver <git@mavit.org.uk>
Date: Fri, 5 May 2023 21:16:51 +0100
Subject: [PATCH] Variable ediff-auto-refine doesn't always default to "on"
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* doc/misc/ediff.texi (Refinement of Difference Regions): mention that
“on” is the default for ediff-auto-refine only on suitable displays.
---
doc/misc/ediff.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/misc/ediff.texi b/doc/misc/ediff.texi
index ce6cb8c9bd6..82bb03fe201 100644
--- a/doc/misc/ediff.texi
+++ b/doc/misc/ediff.texi
@@ -1783,7 +1783,7 @@ Refinement of Difference Regions
@vindex ediff-auto-refine
This variable controls whether fine differences within regions are
highlighted automatically (``auto-refining''). The default is yes
-(@samp{on}).
+(@samp{on}) on suitable displays.
On a slow machine, automatic refinement may be painful. In that case,
you can turn auto-refining on or off interactively by typing
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#63318: Variable ediff-auto-refine doesn't always default to "on"
2023-05-05 20:21 bug#63318: Variable ediff-auto-refine doesn't always default to "on" Peter Oliver
@ 2023-05-06 6:17 ` Eli Zaretskii
2023-05-08 10:26 ` Peter Oliver
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2023-05-06 6:17 UTC (permalink / raw)
To: Peter Oliver; +Cc: 63318
> Date: Fri, 5 May 2023 21:21:50 +0100 (BST)
> From: Peter Oliver <p.d.oliver@mavit.org.uk>
>
> Document that variable ediff-auto-refine doesn't always default to "on".
Wouldn't it be better to instead fix this, so that the default is
always "on"?
Why doesn't Ediff turn on ediff-auto-refine for all terminals?
AFAICT, it only needs faces (basically, colors), and we support that
on all terminals nowadays? So I think we should simply change the
default value (which will also solve bug#63317). Or what am I
missing?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#63318: Variable ediff-auto-refine doesn't always default to "on"
2023-05-06 6:17 ` Eli Zaretskii
@ 2023-05-08 10:26 ` Peter Oliver
2023-05-13 14:02 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Peter Oliver @ 2023-05-08 10:26 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 63318
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
On Sat, 6 May 2023, Eli Zaretskii wrote:
>> Date: Fri, 5 May 2023 21:21:50 +0100 (BST)
>> From: Peter Oliver <p.d.oliver@mavit.org.uk>
>>
>> Document that variable ediff-auto-refine doesn't always default to "on".
>
> Wouldn't it be better to instead fix this, so that the default is
> always "on"?
>
> Why doesn't Ediff turn on ediff-auto-refine for all terminals?
> AFAICT, it only needs faces (basically, colors), and we support that
> on all terminals nowadays? So I think we should simply change the
> default value (which will also solve bug#63317). Or what am I
> missing?
I assumed that this complication was present because there exist displays on which auto-refinement isn’t desirable.
If that’s no-longer the case, then great, simplifying the default to always be “on” certainly sounds like the best way to go to me. Attached is a patch to do that instead.
--
Peter Oliver
[-- Attachment #2: Type: text/plain, Size: 951 bytes --]
From 500850a82e07961dd98187428a5a1768f5e77682 Mon Sep 17 00:00:00 2001
From: Peter Oliver <git@mavit.org.uk>
Date: Mon, 8 May 2023 11:24:53 +0100
Subject: [PATCH] Always default ediff-auto-refine to 'on
* lisp/vc/ediff-diff.el (ediff-auto-refine): always default to 'on.
---
lisp/vc/ediff-diff.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/vc/ediff-diff.el b/lisp/vc/ediff-diff.el
index 832e3933df9..0ee973a4de6 100644
--- a/lisp/vc/ediff-diff.el
+++ b/lisp/vc/ediff-diff.el
@@ -142,7 +142,7 @@ ediff-diff-status
;;; Fine differences
-(ediff-defvar-local ediff-auto-refine (if (ediff-has-face-support-p) 'on 'nix)
+(ediff-defvar-local ediff-auto-refine 'on)
"If `on', Ediff auto-highlights fine diffs for the current diff region.
If `off', auto-highlighting is not used. If `nix', no fine diffs are shown
at all, unless the user force-refines the region by hitting `*'.
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#63318: Variable ediff-auto-refine doesn't always default to "on"
2023-05-08 10:26 ` Peter Oliver
@ 2023-05-13 14:02 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2023-05-13 14:02 UTC (permalink / raw)
To: Peter Oliver; +Cc: 63318-done
> Date: Mon, 8 May 2023 11:26:47 +0100 (BST)
> From: Peter Oliver <p.d.oliver@mavit.org.uk>
> cc: 63318@debbugs.gnu.org
>
> > Why doesn't Ediff turn on ediff-auto-refine for all terminals?
> > AFAICT, it only needs faces (basically, colors), and we support that
> > on all terminals nowadays? So I think we should simply change the
> > default value (which will also solve bug#63317). Or what am I
> > missing?
>
> I assumed that this complication was present because there exist displays on which auto-refinement isn’t desirable.
>
> If that’s no-longer the case, then great, simplifying the default to always be “on” certainly sounds like the best way to go to me. Attached is a patch to do that instead.
Thanks, installed on the master branch (after applying the necessary
fix).
Closing the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-13 14:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-05 20:21 bug#63318: Variable ediff-auto-refine doesn't always default to "on" Peter Oliver
2023-05-06 6:17 ` Eli Zaretskii
2023-05-08 10:26 ` Peter Oliver
2023-05-13 14:02 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).