From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63589: [PATCH] 29.0.91; crash after creating graphical frames via emacsclient when compiled with cairo-xcb Date: Sun, 21 May 2023 17:30:09 +0300 Message-ID: <83o7mdrc3y.fsf@gnu.org> References: <871qj9246a.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29655"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63589@debbugs.gnu.org, tmdmelo@gmail.com To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 21 16:30:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q0k4j-0007a3-Rc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 May 2023 16:30:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q0k4S-0005Xe-JX; Sun, 21 May 2023 10:30:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0k4R-0005XN-2z for bug-gnu-emacs@gnu.org; Sun, 21 May 2023 10:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q0k4Q-0005O3-QP for bug-gnu-emacs@gnu.org; Sun, 21 May 2023 10:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q0k4Q-000710-9G for bug-gnu-emacs@gnu.org; Sun, 21 May 2023 10:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 May 2023 14:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63589 X-GNU-PR-Package: emacs Original-Received: via spool by 63589-submit@debbugs.gnu.org id=B63589.168467940026936 (code B ref 63589); Sun, 21 May 2023 14:30:02 +0000 Original-Received: (at 63589) by debbugs.gnu.org; 21 May 2023 14:30:00 +0000 Original-Received: from localhost ([127.0.0.1]:60944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0k4N-00070O-PH for submit@debbugs.gnu.org; Sun, 21 May 2023 10:30:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0k4K-000709-9U for 63589@debbugs.gnu.org; Sun, 21 May 2023 10:29:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0k4E-0005AX-V8; Sun, 21 May 2023 10:29:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ABJuDrRyv+ORFTspKKvTYcUoFcagflnt0XYdTvXuXNM=; b=TSK/KzKT3has o7i8aHlX3myneoL8yVDQKkz8jVl4f20eEf0WhU7hT5RZ/NVJZ+lWyfenQf7CsfYp+5Mz20bh5VsB7 wjf+R+Y5FvVGBlfVSwy/KJ5o96ISDtmFqW0AAMTtYREkti7sHwoVCBNoBa33ookftDznXT8JWlrwY 5iuZHFA0xm0ciSMRnKp8/n8KnALglVgD7rSXL2DttRN+qsefxDdXv0WKVEH7F/rXkIknL/k2drzjQ ga3lOmN851+qF4Vtj3HR8IHXRFF/LuUiOsUGG4THDHZ4aHKwrSlUfHdsRw9dsRe+uamFFjmhJNWce Uey2ev080Vy96YmcHS5tYQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0k4E-0004LU-Ek; Sun, 21 May 2023 10:29:50 -0400 In-Reply-To: <871qj9246a.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262103 Archived-At: > Cc: 63589@debbugs.gnu.org > Date: Sun, 21 May 2023 21:40:45 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Thiago Melo writes: > > > Here's a patch to fix this issue. It was created on top of the > > emacs-29 branch, commit 6b60c81. > > > > It's based on the suggestion from the cairo mailing list (see the link > > I sent in my original message here). It ensures that the cairo device > > associated with the cairo-xcb surfaces in the display is destroyed > > before closing the display. > > > > It can probably be improved. It could even be extended to handle > > cairo-xlib. In the cairo mailing list, they mentioned one corner case > > where the xlib device is not properly destroyed: when cairo is > > unloaded before the X11 connection is closed. > > I would like to know the details of the X error that caused the display > connection to be closed in the first place: this change is too large for > the release branch, but we may be able to fix the X error. What I would like to understand is how come this didn't happen until now? The Cairo build is the default since Emacs 28, is it not?