From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63829: 29.0.90; project-find-file's future history breaks with common-parent-directory Date: Sat, 03 Jun 2023 15:48:40 +0300 Message-ID: <83o7lw90ev.fsf@gnu.org> References: <83r0qubbtk.fsf@gnu.org> <2790cb95-cfc8-40ee-2a89-d9effe2c2060@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12437"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 63829@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 03 14:48:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5QgF-000348-G3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Jun 2023 14:48:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5Qfs-0007Py-WD; Sat, 03 Jun 2023 08:48:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5Qfq-0007Pp-Tf for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 08:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5Qfq-0004y2-K8 for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 08:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5Qfq-0001DI-18 for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 08:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Jun 2023 12:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63829 X-GNU-PR-Package: emacs Original-Received: via spool by 63829-submit@debbugs.gnu.org id=B63829.16857964804643 (code B ref 63829); Sat, 03 Jun 2023 12:48:01 +0000 Original-Received: (at 63829) by debbugs.gnu.org; 3 Jun 2023 12:48:00 +0000 Original-Received: from localhost ([127.0.0.1]:41774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5Qfn-0001Cn-Et for submit@debbugs.gnu.org; Sat, 03 Jun 2023 08:48:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5Qfj-0001Bt-DV for 63829@debbugs.gnu.org; Sat, 03 Jun 2023 08:47:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5Qfd-0004wf-Pd; Sat, 03 Jun 2023 08:47:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eGUg3CmI0Piy8MPLylfklrVuuI6l/6Rc1xGr/K1wGyI=; b=EWiIQNLNWS3o BP16rYqtWPRBa4rUCfPrK7S5LRyjbpz13uX6Qa+5AM3w9HgNNrVxbbqfDM4xWML4frik+SR3ALfJM y2QLuGp9A8/0v/3FD/vs/p2hHJJh8PlrVQw1GYnvf4B8h8oqoNPw0wQo5nJAee41M6M1+k0d7afrE wKBOvwoXoENkr0Yj7Az2bQqV6ZjeD6TySDKcDIQJtjbb2MnhnOReyQknVGwShPI5ScoNa0VLNJIVF u7UWTDXFiLnM78Cqt9jsFbJ9n+oUy+jGksiXauqTgaW89fkOlxtJJHJbkVZXEzb47IPgCfoZ0GoOq drrJmhnCqG24Zqm7E92o+g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5Qfd-00043j-9N; Sat, 03 Jun 2023 08:47:49 -0400 In-Reply-To: <2790cb95-cfc8-40ee-2a89-d9effe2c2060@gutov.dev> (message from Dmitry Gutov on Sat, 3 Jun 2023 15:19:55 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262829 Archived-At: > Date: Sat, 3 Jun 2023 15:19:55 +0300 > Cc: 63829@debbugs.gnu.org > From: Dmitry Gutov > > On 02/06/2023 09:47, Eli Zaretskii wrote: > >> From: Spencer Baugh > >> Date: Thu, 01 Jun 2023 18:32:29 -0400 > >> > >> 1. emacs -Q > >> 2. Open a project where project-files only returns files in a certain > >> subdirectory. For example, a git repo /repo where the only file is > >> "dir/file.txt". > >> 3. Open dir/file.txt > >> 4. C-x p f ;; project-find file > >> 5. Observe that the prompt is "Find file in /repo/dir: " which correctly > >> contains the common parent directory between all the paths returned by > >> project-files. > >> 6. M-n ;; next-history-element > >> 7. The minibuffer now contains "dir/file.txt". RET will fail to > >> open the file. > >> > >> Instead, the common parent directory should be stripped from the "future > >> history" element. > > > > From my POV, this is a clear sign of too many kludges which override > > the usual Emacs conventions of what is default-directory. Stripping > > the parent directory is IMO not the right solution; instead, the > > default-directory of the command should be set so that what you want > > happens automatically. If you go the way of patching up the code > > instead of fixing this fundamental problem, there will be no end to > > patching up. > > TBH, I'm not sure which particular change you were proposing. I was talking about the description of the problem, and what conclusion it caused me to draw. > Do you like the patch I posted? It could be considered somewhere in that > direction. I don't know enough about the details to have opinion of any importance. But if the change goes in the direction I thought we should go, then that's good. > Should it go to emacs-29 or master? Unless this is a bad problem, I'd prefer that the change goes to master. > >> (As a separate point: I ran into this while adding a feature for > >> switching between projects with similar directory structures. I want to > >> include the relative path in the starting project in the "future > >> history", so that when you have a file in projectA open, you can switch > >> to the same file in projectB with C-x p p f M-n RET. For example, > >> switching between the same file in multiple clones of Emacs. But sadly > >> the future history doesn't work properly right now even in a single > >> project) > > > > Once again, this should work by using the right value of > > default-directory; having relative filenames in the history up front > > is not TRT. Relative file names in Emacs are always interpreted > > relatively to default-directory, so if you start using relative names > > disregarding default-directory, you will eventually run into trouble, > > as various file-related primitives will fail with ENOENT. > > The problem here is that is a different/new scenario where Spencer wants > to have a file name from one project be applied to another project. It > seems like using absolute names would rather go in the opposite direction. If some command wants to produce file names in a different directory, then that command should do something like (expand-file-name (file-name-nondirectory FILENAME) NEW-DIRECTORY) The code which produces the original FILENAME should still produce an absolute file name (or record its directory in some other way); it should not know/assume anything about potential uses of that file name. > > If the default-directory can be different for some elements of > > history, perhaps each element should have the default-directory > > metadata with it, e.g., as a property. Or maybe the history should > > hold absolute file names, and M-n etc. should convert it to relative > > as appropriate. > The latter is mostly what happens. I very much hope so, because anything else is going in the wrong direction.