From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63988: 30.0.50; Recent header line format changes cause spin/seg fault with format-mode-line Date: Sat, 10 Jun 2023 14:22:58 +0300 Message-ID: <83o7lnzhm5.fsf@gnu.org> References: <831qij24qm.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16748"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63988@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 10 13:23:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7wgk-000493-UH for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Jun 2023 13:23:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7wgV-0007f8-A9; Sat, 10 Jun 2023 07:23:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7wgT-0007en-Do for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 07:23:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7wgP-0007dE-ST for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 07:23:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7wgP-0006bd-N6 for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 07:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 11:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63988 X-GNU-PR-Package: emacs Original-Received: via spool by 63988-submit@debbugs.gnu.org id=B63988.168639617825367 (code B ref 63988); Sat, 10 Jun 2023 11:23:01 +0000 Original-Received: (at 63988) by debbugs.gnu.org; 10 Jun 2023 11:22:58 +0000 Original-Received: from localhost ([127.0.0.1]:33379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7wgL-0006b5-In for submit@debbugs.gnu.org; Sat, 10 Jun 2023 07:22:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7wgI-0006ap-O4 for 63988@debbugs.gnu.org; Sat, 10 Jun 2023 07:22:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7wgB-0007WQ-KK; Sat, 10 Jun 2023 07:22:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pV8etFRVbB9IMNw0DGFipdPIeHCI81bc9ESR+EmZq7A=; b=RZsZUwl8sZfs mQh2JhOb7HcnesAietIaGHo6FrSPt46tvo+iRdxxIKbFYmt5MCINKNIjyTqJKl9GvyPDuDRwct8ND O4UkZ45mEMbFLZCQRFk0kS+kRNIIfENB1fp8kATDB0HIfEQE+miXkuU1uSR+aAg3+HO25kcfKcOcO hDkppqbqVd079AUr4fcxoFoRUpESllfR8vb7pFOl9dc4tljdPC2XSL3fyQrChP5nNLt7ne45NtPZ6 Oq/WmbwtvsU+LkBDIqpKdm4WNb2WFdV1qHcU6oQ2JKKI7Kztn8hQ8Hfbe5+kxt+VlmB8g60sVO1fs tcvGxtjuFhbD+w+/GxiAYg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7wgB-0002FJ-4F; Sat, 10 Jun 2023 07:22:47 -0400 In-Reply-To: (message from Aaron Jensen on Sat, 10 Jun 2023 07:08:20 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263213 Archived-At: > From: Aaron Jensen > Date: Sat, 10 Jun 2023 07:08:20 -0400 > Cc: 63988@debbugs.gnu.org > > > But what is the purpose of such a strange (to use a civilized word) > > setting of header-line-format? Why do you need :eval at all in this > > case? > > > > IOW, why not say "don't do that" and be done? > > It's a minimal repro for an issue I encountered with a package that does this: > > https://github.com/rougier/nano-modeline/blob/master/nano-modeline.el#L532 > > It's how this modeline/header line adds line number/cursor position to > a more complicated line. As I understand it, it has to format it first > in order to use its width to properly right align it: > > https://github.com/rougier/nano-modeline/blob/master/nano-modeline.el#L278 > > Is there a better way to do this? Use just 'format'? I still don't understand why they use format-mode-line there. > > So maybe we should declare this feature a failed experiment and remove > > it? > > I'll admit I don't really understand the change. Is it actually > evaluating the cdr of the eval form up to two additional times to in > order to determine whether or not to display the headerline at all? Only two? > Wouldn't this have performance implications? Probably, although I wouldn't expect the performance to suffer too much. Header-line is rarely used. But yes, that's one more implication to consider when introducing such minor convenience features.