From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Date: Fri, 23 Jun 2023 14:01:17 +0300 Message-ID: <83o7l61lz6.fsf@gnu.org> References: <87o7ri74qv.fsf@localhost> <7ccb0e8131f84ca2ea0f0c0aed11dc197b578a64.camel@laposte.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17079"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60467@debbugs.gnu.org, Gregory Heytings , Ihor Radchenko To: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric?= Giquel , Stefan Monnier , Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 23 13:03:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCeZK-0004BW-BK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jun 2023 13:03:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCeZ6-0003zG-Ej; Fri, 23 Jun 2023 07:02:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCeYh-0003y6-Bx for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 07:02:35 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCeYE-000301-AX for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 07:02:17 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qCeYE-0000IV-0t for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 07:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jun 2023 11:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.16875180741084 (code B ref 60467); Fri, 23 Jun 2023 11:02:01 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 23 Jun 2023 11:01:14 +0000 Original-Received: from localhost ([127.0.0.1]:37766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCeXS-0000HQ-9E for submit@debbugs.gnu.org; Fri, 23 Jun 2023 07:01:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCeXQ-0000HE-LZ for 60467@debbugs.gnu.org; Fri, 23 Jun 2023 07:01:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCeXK-0002mS-3B; Fri, 23 Jun 2023 07:01:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=XKso+qGt7ONhbjMlcOcGdEgZ4HaGyP3w3Wmv0phC5bk=; b=jY8AEWYiH038z+V2rNQV 4dz5eg+WQ/HF4yAPUrcgXjW/n+7eHXLhHhYDXGLsCYYaT+pMLGULIgu791xd7wLl7srWBRLR0iJs9 k8jz9S5iILGoycCna8V+J/zuu2MbxVgLR8hEyK/A84RXS+H7sUJ3LXjWJyzFghG1kWXkA115JeisK 55aKk9rOtkN/r7YXgDWpd7m7FRwZ0bAlfPzEXMFQoW9yXIEZpkv1JmRwTplHf284UkLLZEXbmKWIB V+JgIw8UCN17Y8e2iPsyCJXZ0sFekeFX8KV+Hr7SZX8kboePxsJFwPAP5Ke6opS9AWKA0f2c8Y8b6 mBOwoFKVG7SMYA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCeXI-0000w6-PB; Fri, 23 Jun 2023 07:01:05 -0400 In-Reply-To: <7ccb0e8131f84ca2ea0f0c0aed11dc197b578a64.camel@laposte.net> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263946 Archived-At: [Please don't change the Subject when you reopen a bug.] > Date: Thu, 22 Jun 2023 21:28:44 +0200 > From: Frédéric Giquel via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Hi all, > > I'm reopening this bug because the fix has introduced a new problem. > > This can be highlighted with the following procedure (verified with > Emacs 29.0.92) : > 1. Open a file: emacs -Q > 2. Move point to a line you can comment > 3. M-x comment-line > 4. M-x undo > 5. Check buffer modification status in modeline or use (buffer- > modified-p) > > Without the patched version of combine-change-calls-1, the buffer > status is "not modified since last save". Same result if you use > another command, for example kill-line, at step 2. > With new version of combine-change-calls-1, the buffer is seen as > modified. > > I'm not sure but I imagine it has something to do with the lack of > timestamp in buffer-undo-list created by combine-change-calls-1. Stefan, can you please look into this?