From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62732: 29.0.60; uniquify-trailing-separator-p affects any buffer whose name matches a dir in CWD Date: Thu, 13 Jul 2023 07:50:43 +0300 Message-ID: <83o7kg5s9o.fsf@gnu.org> References: <87h6tpn8d5.fsf@catern.com> <87edotn7sx.fsf@catern.com> <87edlhm6wq.fsf@catern.com> <87o7kklf9c.fsf@catern.com> <83r0pf9b7d.fsf@gnu.org> <83fs5v8tsw.fsf@gnu.org> <83edlf89qp.fsf@gnu.org> <83v8eq7j3i.fsf@gnu.org> <83pm4y79dw.fsf@gnu.org> <83y1jl5jrq.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32302"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@catern.com, 62732@debbugs.gnu.org To: monnier@iro.umontreal.ca, sbaugh@janestreet.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 13 06:51:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJoIO-0008D4-EW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jul 2023 06:51:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJoIG-0006Qy-W4; Thu, 13 Jul 2023 00:51:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJoIA-0006QJ-0y for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 00:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJoI9-0005yy-OC for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 00:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJoI9-0002gq-Ke for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 00:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2023 04:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62732 X-GNU-PR-Package: emacs Original-Received: via spool by 62732-submit@debbugs.gnu.org id=B62732.168922384210302 (code B ref 62732); Thu, 13 Jul 2023 04:51:01 +0000 Original-Received: (at 62732) by debbugs.gnu.org; 13 Jul 2023 04:50:42 +0000 Original-Received: from localhost ([127.0.0.1]:53146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJoHp-0002g6-WC for submit@debbugs.gnu.org; Thu, 13 Jul 2023 00:50:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJoHo-0002fl-6z for 62732@debbugs.gnu.org; Thu, 13 Jul 2023 00:50:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJoHi-0005jF-Qt; Thu, 13 Jul 2023 00:50:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HORoIiBM8mJeXd+XTvaOthjsk5/btsuSMpE53vqHJpQ=; b=JHqNBrrpZppr u1+YMXoae1EIH0wMQhUsSE/cZcecraymYvZYRyczfk0nSWgWkmXse5DGCgJq570jb75dDK/mOXRjg nh0pptUxi2qH6MJNBUZj622FA2N2g0SULbo4QYT8rTwuLXXnXgQelIm4uLQxjMQ2lv+HIKDvmSI+q 5on3HypFOkDYC7B3iSkXCU7NhrohxxgMmJLHphSyCQ9svr/VpldRbdj0b2iwKh2up3b81Ang56OIR 89MlcXPuCw+1mwAVdHPjs6mIIdCQ19L5fhOw/wOrmOcXqV7eRax052MPe6LrM7M+5Zihj2Q7QqyWZ +KDUfuIV94F47nfWzkoa2A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJoHc-0000XG-8D; Thu, 13 Jul 2023 00:50:32 -0400 In-Reply-To: <83y1jl5jrq.fsf@gnu.org> (message from Eli Zaretskii on Wed, 12 Jul 2023 16:42:01 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264994 Archived-At: > Cc: sbaugh@janestreet.com, 62732@debbugs.gnu.org, sbaugh@catern.com > Date: Wed, 12 Jul 2023 16:42:01 +0300 > From: Eli Zaretskii > > > I can see 3 ways to provide this info: > > > > 1- use `file-directory-p`. > > 2- add a boolean `directory` argument to `create-file-buffer`. > > 3- use the presence of a trailing directory separator in the filename. > > > > Those 3 are very close to each other, in practice, so we're pretty much > > in bikeshed territory. > > > > My preference is (3) first, (2) second, and (1) last. > > I prefer (1), because it avoids requesting the callers to remember to > ensure that every directory ends in a slash. So how about compromising on a variant of (2): we add an optional DIRECTORY-P argument, and if FILENAME doesn't end in a slash, but DIRECTORY-P is non-nil, create-file-buffer will append a slash?