From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59458: [PATCH] Fix tracing for advanced scoring Date: Fri, 08 Sep 2023 09:04:52 +0300 Message-ID: <83o7idxksb.fsf@gnu.org> References: <20221121213055.2387178-1-stlman@poczta.fm> <831qpsyaar.fsf@gnu.org> <877czkf8g3.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22417"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eric@ericabrahamsen.net, larsi@gnus.org, 59458@debbugs.gnu.org, stlman@poczta.fm To: Stefan Kangas , Andrew Cohen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 08 08:07:04 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeUe0-0005dJ-DR for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Sep 2023 08:07:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeUdS-00013O-Fv; Fri, 08 Sep 2023 02:06:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeUcy-0000bv-Dt for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 02:06:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeUcy-0005hZ-4f for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 02:06:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeUcz-0002Ji-RX for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 02:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Sep 2023 06:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59458 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59458-submit@debbugs.gnu.org id=B59458.16941531218854 (code B ref 59458); Fri, 08 Sep 2023 06:06:01 +0000 Original-Received: (at 59458) by debbugs.gnu.org; 8 Sep 2023 06:05:21 +0000 Original-Received: from localhost ([127.0.0.1]:41980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeUcL-0002Ik-BA for submit@debbugs.gnu.org; Fri, 08 Sep 2023 02:05:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeUcH-0002IU-1L for 59458@debbugs.gnu.org; Fri, 08 Sep 2023 02:05:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeUc6-0005Cl-Ch; Fri, 08 Sep 2023 02:05:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ykT6oYKWRd+qTd6eiVl3aMLQOdpgU4RqJtRokTZAspQ=; b=Zhl8RTBfRrP0ErNp3aOH 6182Zacwn88G+4oA4t6e9RzqAkKT6mOLDVGCCHVCKGstnirMZkVo1bRTEKghfUWe6F0vvKrGnEZlp qT0M0wQHOwbw/NaSep5sofEIEB+ewQXKnloBKis6P9X+JjO2AjpPhIELXlQoKqJEffPsVTTtjnGRH FIgA0I1aJF3k5PBHabEkM03qWatNyGtA12d+rEBRoRbQ+saPk4RWlrmgKmEfZrv1p+BNNjJgqvA2l VGagx2bZqqiRetH3wbXWXhbU25VoFdTDTrB0qj4RySgdI1lwwKUq6Occ3eLTj6WMzS/PVWx5Q2zWH +sdQ/a4bXEqWiQ==; In-Reply-To: (message from Stefan Kangas on Thu, 7 Sep 2023 14:07:57 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269725 Archived-At: > From: Stefan Kangas > Date: Thu, 7 Sep 2023 14:07:57 -0700 > Cc: Eli Zaretskii , Lars Ingebrigtsen , 59458@debbugs.gnu.org, > Łukasz Stelmach > > Eric Abrahamsen writes: > > > Eli Zaretskii writes: > > > >>> Cc: Łukasz Stelmach > >>> From: Łukasz Stelmach > >>> Date: Mon, 21 Nov 2022 22:30:55 +0100 > >>> > >>> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing > >>> code outside of if so it's executed for both branches. > > > > I'm not very familiar with this code (this is actually the first I'm > > hearing of gnus-logic.el), so I hope Lars will chime in. It makes sense > > that tracing should happen whether or not the rule matched? But what > > about the sexp before that? Would we be pushing the mail-header-number > > and new score to `gnus-newsgroup-score' only if the rule *wasn't* > > successful? > > > > I think this one should wait for Lars. If we don't hear from him and > > it's holding things up, I can look more closely. > > Eric, > > It would be great if you could help review this. Thanks in advance. Adding Andrew, in case he could have some ideas or comments.