From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67124: 26.3; query-replace Arg out of range with comma option (at end-buffer) Date: Thu, 16 Nov 2023 16:55:39 +0200 Message-ID: <83o7ftpx1w.fsf@gnu.org> References: <020a72b2-b896-4ecf-abab-111a6c1c9eac@medialab.sissa.it> <83cywfuwta.fsf@gnu.org> <83pm0du49e.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29529"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gabriele@medialab.sissa.it, 67124@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 16 15:56:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3dmu-0007Q6-TT for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Nov 2023 15:56:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3dmm-000615-Et; Thu, 16 Nov 2023 09:56:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3dml-00060n-0r for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 09:56:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3dmk-0007Al-OY for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 09:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3dmk-0006aL-1Y for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 09:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Nov 2023 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67124 X-GNU-PR-Package: emacs Original-Received: via spool by 67124-submit@debbugs.gnu.org id=B67124.170014656025236 (code B ref 67124); Thu, 16 Nov 2023 14:56:02 +0000 Original-Received: (at 67124) by debbugs.gnu.org; 16 Nov 2023 14:56:00 +0000 Original-Received: from localhost ([127.0.0.1]:56409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3dmh-0006YV-CI for submit@debbugs.gnu.org; Thu, 16 Nov 2023 09:55:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3dme-0006Sx-Pq for 67124@debbugs.gnu.org; Thu, 16 Nov 2023 09:55:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3dmY-00078n-D2; Thu, 16 Nov 2023 09:55:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=T5f2o/HufzKxOW2tIdK2FGPGEP1p805VKAGqdGwbldc=; b=dI5atwS/EE7t 3PO8EP3JwfPhi5G6BlmwU7ZCcnlRrhldZBOc10be+KaUjkkT+TVwbimi8ajwgv161N/CYdwGEtivl Jib1xn3r6MJmaPfNJPYcN8oxtUgch23yxKp7E1g2rgRwcI8EeMPnxqOlU1CdLso3Vba5REKPpbKxk erZmP5kG2AXyLgQ6Yon0MOm23vLx+6Q50IpNaUNvj7oa07hWeb0Kghnf98iZ5bQa4FKPm2uAhJnLA Rg8IHjjNCtc92Z7U2DRP9DfDxSGeVmTJwe+iaRY1P0IoL8AXkB/Q+v5xoq7OA1Vk21/KMCNwABz+F b1gzaMdFUEYsLp75Pmt0hw==; In-Reply-To: (message from Stefan Monnier on Thu, 16 Nov 2023 09:29:22 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274461 Archived-At: > From: Stefan Monnier > Cc: gabriele@medialab.sissa.it, 67124@debbugs.gnu.org > Date: Thu, 16 Nov 2023 09:29:22 -0500 > > >> > ;; `replace-match' leaves point at the end of the replacement text, > >> > ;; so move point to the beginning when replacing backward. > >> > (when backward (goto-char (nth 0 match-data))) > >> > >> and (nth 0 match-data) == (match-beginning 0), no? > > See above: not exactly. > > I believe the numerical value of (nth 0 match-data) will be the same at > this point as that of (nth 0 (match-data)) because we just passed that > very value to `set-match-data`, and that is always equal > (numerically) to (match-beginning 0). > Since the only thing we do with that value is pass it immediately to > `goto-char`, it makes no difference if it's a marker or an integer, no? > > What am I missing? What are you trying to understand? The cause of the bug is that we force the match data back to the buffer position before the replace. As long as that is not removed, the bug will remain. What my kludge did is simply use a marker, so the adjusted position is not clobbered.