From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55871: Acknowledgement (27.1; vc-git.el log view 'a', 'f', 'd' do not work when following renames) Date: Fri, 15 Dec 2023 17:10:22 +0200 Message-ID: <83o7ero61t.fsf@gnu.org> References: <78f97339-2aca-0dbd-4cb4-3532af78a895@yandex.ru> <1b16a642-8a85-e693-66fc-41c37df24908@yandex.ru> <36b48587-a723-73ae-fefb-886d69d04ec8@yandex.ru> <83y1dvobun.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39674"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55871@debbugs.gnu.org, n.oje.bar@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 15 16:11:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rE9qf-000A4z-OQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Dec 2023 16:11:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rE9qF-0004SL-6m; Fri, 15 Dec 2023 10:11:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rE9qB-0004Qd-Ff for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2023 10:11:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rE9qA-0000zR-Om for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2023 10:11:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rE9qA-0007q1-EX for bug-gnu-emacs@gnu.org; Fri, 15 Dec 2023 10:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Dec 2023 15:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55871-submit@debbugs.gnu.org id=B55871.170265304730107 (code B ref 55871); Fri, 15 Dec 2023 15:11:02 +0000 Original-Received: (at 55871) by debbugs.gnu.org; 15 Dec 2023 15:10:47 +0000 Original-Received: from localhost ([127.0.0.1]:53348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rE9pu-0007pW-Sm for submit@debbugs.gnu.org; Fri, 15 Dec 2023 10:10:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rE9ps-0007pI-DS for 55871@debbugs.gnu.org; Fri, 15 Dec 2023 10:10:45 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rE9pm-0000yL-2W; Fri, 15 Dec 2023 10:10:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZQpl6CbzOQVSpWKvW2TzrZXpSvKeeU0JnLcXqBRhlxc=; b=GgqqPd5SdsCz 9eQT6RmfX7iCEin1Anoyswa2LauOXVysUxQkUVGl93DUtlrE6U31tWkkEG+oUvEQ8BOWFMQ/vDFVC eP8m78VIFHT+7qlp52qNlmmjiYa7Zm1YXqmIY0c52S0UElZvauRe6ef6V1a3/8z//tEbBav0L3ial 6lo7aFeMAJBJe+SQcBUdT79E7aChtnch39u8dSv3+hf/+ByWHaeghQ6eFJVoLkiPdVpHDQkSHtDdF m/N1zKaHd/7OK+/hOJztEmTHtl62FfcTQanlkXwhR45uz5aMPClk0Fj0rmdde3wV7mmQEmAC7n6hh CCdQAiaJ9e8bBbV8NpLNIw==; In-Reply-To: (message from Dmitry Gutov on Fri, 15 Dec 2023 16:39:04 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276272 Archived-At: > Date: Fri, 15 Dec 2023 16:39:04 +0200 > Cc: 55871@debbugs.gnu.org, n.oje.bar@gmail.com > From: Dmitry Gutov > > > FYI: 'd' and 'f' work with bzr without any changes. > > To my understanding, Bazaar doesn't really exist in this day and age, so > should we pay extra attention to it in this NEWS entry? Bazaar is still being developed, but I don't know how important it is nowadays. I do use it here, FWIW (and keep the old repository under Bazaar, from before the switch, for the rare occasion I need to look up or try something there). > We could say that the problem is relevant to Git and Hg, and the current > solution only helps Git. I'm not sure what's the best phrasing, however, > which won't bloat the NEWS entry too much. That'd be fine, and the wording could just use what you say above. > > 'a' doesn't work > > (evidently, "bzr annotate -r REVISION FILE" doesn't work when FILE did > > not exist in REVISION, but was renamed by a later revision, and one > > needs to run "bzr status -Sr REVISION" and look for the "renamed" > > report in the result, which will then provide the previous name). > > But when we're asking for 'annotate' for a file in some old revision > (under old name), it won't be the same revision where it had been > renamed, 99% of the time. It doesn't matter. The above-mentioned bzr command will show the telltale "RM old => new" status. Keep in mind that "-r REVISION" in bzr means "since REVISION till the current head". > > (FTR: I used src/unexcoff.c file to test this.) > > > >> +*** Support for viewing file change history across renames. > >> +When a fileset's VC change history ends at a rename, we now print the > >> +old name(s) and a button which jumps to their history. Only supported > >> +with Git at the moment. > > > > I think this should at least tell that for files under Bazaar, the VC > > change history will always include the renames. Looks like Mercurial > > is in the same department as Git? > > More or less, yes, here's an even older bug report: > https://debbugs.gnu.org/13004 > > > If so, I think the text should say > > that this is not supported for Mercurial yet, and that Bazaar shows > > the entire history, including renames, by default. Or something like > > that. > > I don't want to make it a sticking point, but according to the wiki > entry Monotone also tracks renames. We won't be mentioning it here, will we? vc-monotone is not part of Emacs, right? It is okay to say "is not yet supported for Hg".