From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Sun, 17 Dec 2023 14:06:00 +0200 Message-ID: <83o7epjaon.fsf@gnu.org> References: <878r919qfh.fsf@localhost> <87fs06w4ui.fsf@localhost> <83bkaurut9.fsf@gnu.org> <87o7esq319.fsf@localhost> <83bkasrb3f.fsf@gnu.org> <83wmtgpuyf.fsf@gnu.org> <871qboprh3.fsf@localhost> <87y1dwobey.fsf@localhost> <878r5v20gu.fsf@localhost> <83bkapl5zh.fsf@gnu.org> <83zfy9jkoh.fsf@gnu.org> <878r5tglwp.fsf@localhost> <83ttohjet0.fsf@gnu.org> <83sf41jed7.fsf@gnu.org> <87y1dtyu4y.fsf@localhost> <83plz5jdgj.fsf@gnu.org> <87v88xyt2a.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28024"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 17 13:07:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEpvL-00076L-KD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Dec 2023 13:07:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEpvC-00032m-FT; Sun, 17 Dec 2023 07:07:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEpvB-00032H-LN for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 07:07:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEpvB-00053N-Ck for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 07:07:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEpvC-0002Jy-2s for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 07:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Dec 2023 12:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.17028147908867 (code B ref 66117); Sun, 17 Dec 2023 12:07:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 17 Dec 2023 12:06:30 +0000 Original-Received: from localhost ([127.0.0.1]:56664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEpug-0002Iu-Db for submit@debbugs.gnu.org; Sun, 17 Dec 2023 07:06:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEpuc-0002If-7S for 66117@debbugs.gnu.org; Sun, 17 Dec 2023 07:06:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEpuV-0004tG-FQ; Sun, 17 Dec 2023 07:06:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZM+qECnGBGDpTrHucmqkAJ2qGRQ8Dv2xKlOPy/BXawQ=; b=HaoKLsrHYrx/ h6fEPgn0x8kAme9RpA0u8/rriXhVHIJt7xb/0tg6vIfpqCA4v14+DBZ1YIgcJ0f/UShIaI67G3OwO 12IuCXMXobXQCiBE1blojwTiwGqtI4OT6+oowtW3NCUsF4X5Xj2w+QZiqrPZnHH7mlrvgmguQwTLJ F7PLzZL6hG1+h4V8Rq1lFRCeeWGL+2GEr5B487kunn8p3T5Gu7g12WZDpsZlOq/aEWrQG5ntkrcYx ei0jQkJGwClpgw7Avl7Tyz2wcDUyx69Qekg4kuxKm6NwQ3cjIFUkTZAx+BQJZfH+9NFlNkDAhPKAq bKvUbBVUf6pdQa+o8rKKjw==; In-Reply-To: <87v88xyt2a.fsf@localhost> (message from Ihor Radchenko on Sun, 17 Dec 2023 11:19:57 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276418 Archived-At: > From: Ihor Radchenko > Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org, mattias.engdegard@gmail.com, > monnier@iro.umontreal.ca > Date: Sun, 17 Dec 2023 11:19:57 +0000 > > Eli Zaretskii writes: > > > I'm talking specifically about any changes from previous behavior > > visible from Lisp. I think we should test all of the following: > > > > default-value > > default-boundp > > setq-default > > default-toplevel-value > > set-default-toplevel-value > > > > and make sure they all behave exactly the same, both in and out of a > > let-binding. > > The patch did not introduce test failures for make check on my side. Are > there existing tests for buffer-locals? Or do we need to add them? I don't see any such tests. So yes, it would be good to add them. But at the very least we should consider all of the above theoretically and see if any of them are expected/supposed to change as result of this.